[4.6.0] Fix #30133: Entering sticking or fingering, ending on empty text box and clicking away, previously entered text disappears #30147
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Resolves: musescore#30133 Follow-up to musescore@4056c16
The `Async::call` might have fixed some issues, but is apparently not enough to prevent the docking system from getting confused by multiple updates in the same event loop tick. Resolves: musescore#30135 (comment)
We were trying to play it back after it had been deleted because it was empty… Moving the `playElements` call before navigate call is not an option, because it needs to be after `endEdit`.
mike-spa
approved these changes
Sep 26, 2025
cbjeukendrup
deleted the
port/4.6/30133_sticking_fingering_sequence_lost
branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Resolves: #30133
Porting #30135