Fix crash on change system staff visibility in single-system scores #30093
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mike-spa
approved these changes
Sep 25, 2025
Contributor
|
Always hide instrument video1814978373.mp4 |
cbjeukendrup
force-pushed
the
30089_crash_change_system_staff_visibility_in_single_system_score
branch
from
9eba4e4 to
d023728
Compare
Member
Author
|
Pushed a fix. @mike-spa could you please re-check the last commit? Now using |
mike-spa
approved these changes
Sep 26, 2025
See explanation added in `EmptyStavesVisibilityModel::scheduleUpdateData`. Review with "hide whitespace changes". Now, when changing system staff visibility in a single-system score, the popup will close on every change, instead of crashing.
There should be a difference between explicitly laying out the entire score from scratch, or just "accidentally" laying out a range that happens to span the entire score (for example, the first system in a single-system score). This matters especially in `ScorePageViewLayout::prepareScore`, where the `layoutAll` code path is quite drastic. This is a nice addition to the previous commit, because now the system staff visibility popup won't close anymore after every change when used in single-system scores.
cbjeukendrup
force-pushed
the
30089_crash_change_system_staff_visibility_in_single_system_score
branch
from
d023728 to
5ff8a7d
Compare
cbjeukendrup
added a commit
that referenced
this pull request
Sep 26, 2025
Port the less risky part of #30093
cbjeukendrup
deleted the
30089_crash_change_system_staff_visibility_in_single_system_score
branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Resolves: #30089
@mike-spa Do you think the 3rd commit is too risky?