Skip to content

Conversation

@XiaoMigros
Copy link
Contributor

@XiaoMigros XiaoMigros commented Mar 23, 2025

Resolves: #13593

Rebased #20822 after the changes to plugins/extensions. Would be nice to get this into MuseScore 4 still.

  • I signed the CLA
  • The title of the PR describes the problem it addresses
  • Each commit's message describes its purpose and effects, and references the issue it resolves
  • If changes are extensive, there is a sequence of easily reviewable commits
  • The code in the PR follows the coding rules
  • There are no unnecessary changes
  • The code compiles and runs on my machine, preferably after each commit individually
  • I created a unit test or vtest to verify the changes I made (if applicable)

@Eism
Copy link
Contributor

Eism commented Mar 24, 2025

Ahh, we have a problem with the dependency of the engraving module on the notation and project modules.

The easiest way to solve this problem:

  • add an interface to the engraving module, it will have 3 methods - openScore, saveScore, closeScore
  • inject the interface into PluginAPI, call from API methods
  • implement the interface in the project module

@XiaoMigros XiaoMigros force-pushed the readscore-writescore branch 22 times, most recently from 9bfa1ac to 773ccf2 Compare March 26, 2025 18:51
@Jojo-Schmitz
Copy link
Contributor

Please add a

Resloves: #13593

To the initial description, for it to be linked to that issue

@XiaoMigros XiaoMigros force-pushed the readscore-writescore branch from 773ccf2 to 49895e6 Compare May 14, 2025 10:05
@XiaoMigros XiaoMigros force-pushed the readscore-writescore branch from 49895e6 to a3ac2fc Compare May 14, 2025 10:18
@XiaoMigros
Copy link
Contributor Author

Has been dealt with, sorry for the wait!

@XiaoMigros XiaoMigros marked this pull request as ready for review May 14, 2025 10:56
@XiaoMigros XiaoMigros force-pushed the readscore-writescore branch from a3ac2fc to 8ac552c Compare May 14, 2025 10:58
@cbjeukendrup cbjeukendrup requested a review from Eism May 15, 2025 20:09
yaybrianna added a commit to yaybrianna/MuseTracks that referenced this pull request Jun 29, 2025
yaybrianna added a commit to yaybrianna/MuseTracks that referenced this pull request Jun 29, 2025
yaybrianna added a commit to yaybrianna/MuseTracks that referenced this pull request Jun 29, 2025
yaybrianna added a commit to yaybrianna/MuseTracks that referenced this pull request Jun 29, 2025
@XiaoMigros XiaoMigros force-pushed the readscore-writescore branch 2 times, most recently from bf9dc4a to 94fd984 Compare July 15, 2025 11:35
@wwwbagel3
Copy link

Hey guys - wondering if there's been any movement on this? I (and others) eagerly await for these to be added. Thanks!

@DmitryArefiev
Copy link
Contributor

@XiaoMigros This is ready for code review/testing?

@cbjeukendrup
Copy link
Member

Looks like it's awaiting a new review from @Eism (but perhaps a rebase first, by now)

@XiaoMigros XiaoMigros force-pushed the readscore-writescore branch 2 times, most recently from 0345821 to c31f9e7 Compare September 22, 2025 17:52
@XiaoMigros
Copy link
Contributor Author

@DmitryArefiev @Eism The PR is rebased, I've tested it on my Windows device and it seems to be working as expected so I think it's ready for your triage!

@XiaoMigros XiaoMigros force-pushed the readscore-writescore branch from c31f9e7 to e99e0e7 Compare November 2, 2025 04:06
@brunoro
Copy link

brunoro commented Nov 5, 2025

Very excited for this! In my brass band we wrote a plugin to help us format our scores and this would help a lot to migrate our repertoire to MuseScore 4

@brunoro
Copy link

brunoro commented Nov 6, 2025

small update, I just tested this on Mac against commit e99e0e7 and it worked fine. I managed to export pdf, svg, mp3 and midi using the writeScore method.

@dmitrio95 @Eism is there anything I can do to help @XiaoMigros get this across the finish line?

@Auth-Xero
Copy link

Hey, is there any update/ETA on when this may be merged? Thank you!

@cbjeukendrup
Copy link
Member

We plan to merge as many community PRs as possible before the end of this year. This one is relatively high on my list because it looks like it's in a good state and I know it's quite wanted.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

A plugin's readScore(), closeScore() and writeScore() fails

9 participants