Skip to content

Conversation

@octopols
Copy link
Contributor

@octopols octopols commented Jan 27, 2023

Resolves: #13652

Color picker now have alpha value. If the alpha value is 0 and the color picker is launched the value is changed to 255 automatically.

  • I signed the CLA
  • The title of the PR describes the problem it addresses
  • Each commit's message describes its purpose and effects, and references the issue it resolves
  • If changes are extensive, there is a sequence of easily reviewable commits
  • The code in the PR follows the coding rules
  • There are no unnecessary changes
  • The code compiles and runs on my machine, preferably after each commit individually
  • I created a unit test or vtest to verify the changes I made (if applicable)

If the color is invalid it now returns original color in case the background is not white.
@RomanPudashkin RomanPudashkin requested a review from Eism January 31, 2023 08:35
@octopols octopols closed this by deleting the head repository Jan 31, 2023
@Jojo-Schmitz
Copy link
Contributor

Why closing it?

@octopols octopols reopened this Jan 31, 2023
@Jojo-Schmitz
Copy link
Contributor

You should probably squash those 3 commits into just one

"qcombobox": "cpp",
"xhash": "cpp",
"xstring": "cpp",
"xtree": "cpp"
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think, these changes are not needed
Please remove

@octopols
Copy link
Contributor Author

octopols commented Feb 2, 2023

@Jojo-Schmitz I think creating a new PR is my only option

@Jojo-Schmitz
Copy link
Contributor

Sometimes there's no other choice, unfortunately

@octopols
Copy link
Contributor Author

octopols commented Feb 3, 2023

I'll be closing this PR then, I have replaced this with #16201 .

@octopols octopols closed this Feb 3, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Regression: opacity control missing in color picker

4 participants