Skip to content

Noble's crypto BLS #663

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 19 commits into
base: feat/next
Choose a base branch
from
Open

Noble's crypto BLS #663

Show file tree
Hide file tree
Changes from 7 commits
Commits
Show all changes
19 commits
Select commit Hold shift + click to select a range
65d72d7
Redo https://github.com/multiversx/mx-deprecated-sdk-js-wallet/pull/51.
andreibancioiu Sep 22, 2025
0faadd9
Fix test.
andreibancioiu Sep 22, 2025
7e4efd3
Merge pull request #667 from multiversx/feat/next
danielailie Sep 22, 2025
86e8a51
Fixes after Copilot review.
andreibancioiu Sep 22, 2025
4653412
Fix after review etc.
andreibancioiu Sep 22, 2025
fcf5d87
Merge branch 'main' into noble-crypto-bls-research
andreibancioiu Sep 22, 2025
33f6405
Split code vs. tests.
andreibancioiu Sep 22, 2025
5f07745
Small refactoring.
andreibancioiu Sep 22, 2025
85afe13
Merge branch 'feat/next' into noble-crypto-bls-research
andreibancioiu Sep 22, 2025
3fe5512
Fix after merge.
andreibancioiu Sep 22, 2025
1bea9d6
Temporarily add "test vectors for bls".
andreibancioiu Sep 22, 2025
7654ca5
Noble curves v1.7.0.
andreibancioiu Sep 22, 2025
a796a2a
Noble curves v1.8.0.
andreibancioiu Sep 22, 2025
432699a
Noble curves v1.8.2.
andreibancioiu Sep 22, 2025
14acfae
Noble curves v1.9.0. Noble curves has fixed "FpLegendre" (was somehow…
andreibancioiu Sep 22, 2025
c5afd1d
Noble curves v1.9.1. Also, seems like "G.weierstrassEquation()" is go…
andreibancioiu Sep 22, 2025
6bfb910
Noble curves v1.9.2.
andreibancioiu Sep 22, 2025
68c1a5e
Add back "getWeierstrassLikeHerumi", since "G.weierstrassEquation()" …
andreibancioiu Sep 22, 2025
c2481fe
Fix after review (additional comments and tests).
andreibancioiu Oct 1, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
3 changes: 2 additions & 1 deletion package.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -70,7 +70,8 @@
"prettier": "3.2.4",
"protobufjs-cli": "1.1.2",
"ts-node": "9.1.1",
"typescript": "4.1.2"
"typescript": "5.6.2",
"@noble/curves": "1.6.0"
Copy link
Contributor Author

@andreibancioiu andreibancioiu Sep 22, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Only as "dev-dependency" for now (no change of production code).

By the way, a lot happened since multiversx/mx-deprecated-sdk-js-wallet#51 (on top of v1.6.0):

Copy link

Copilot AI Sep 22, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The @noble/curves dependency should be in devDependencies instead of being placed alongside devDependencies like typescript. The formatting is also inconsistent - it should be on a separate line with proper indentation.

Copilot uses AI. Check for mistakes.
Copy link
Contributor Author

@andreibancioiu andreibancioiu Sep 22, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Bad comment. Also, not an issue for now.

Copy link

Copilot AI Sep 22, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The Noble Curves dependency should be moved from devDependencies to dependencies since it's used in production code (imported in the adapter module).

Copilot uses AI. Check for mistakes.
Copy link
Contributor Author

@andreibancioiu andreibancioiu Sep 23, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Adapter module isn't properly advertised (should not be used by client code yet).

},
"peerDependencies": {
"bignumber.js": "^9.0.1",
Expand Down
Loading
Loading