Fix processing type field transaction endpoint #7346
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| return tc, nil | ||
| } | ||
|
|
||
| func (tth *txTypeHandler) ComputeTransactionTypeInEpoch(tx data.TransactionHandler, epoch uint32) (process.TransactionType, process.TransactionType, bool) { |
sstanculeanu
approved these changes
Oct 15, 2025
AdoAdoAdo
approved these changes
Oct 15, 2025
|
✅ Integration Tests passed successfully! 📊 MultiversX Automated Test Report: View Report 🔄 Build Details:
🚀 Environment Variables:
|
|
✅ Integration Tests passed successfully! 📊 MultiversX Automated Test Report: View Report 🔄 Build Details:
🚀 Environment Variables:
|
Codecov Report❌ Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## rc/barnard-patch-3 #7346 +/- ##
===================================================
Coverage 75.05% 75.05%
===================================================
Files 812 812
Lines 134421 134427 +6
===================================================
+ Hits 100891 100898 +7
- Misses 27809 27810 +1
+ Partials 5721 5719 -2 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
ssd04
approved these changes
Oct 17, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Reasoning behind the pull request
processingTypefrom transaction endpointProposed changes
processingTypeOnSourceandprocessingTypeOnDestinationfields based on the block epoch (the epoch of the block in which the transaction was executed), instead of the current epoch.Testing procedure
Pre-requisites
Based on the Contributing Guidelines the PR author and the reviewers must check the following requirements are met:
featbranch created?featbranch merging, do all satellite projects have a proper tag insidego.mod?