Update Index of Reports #7068
Update Index of Reports #7068
Conversation
|
✅ Integration Tests passed successfully! 📊 MultiversX Automated Test Report: View Report 🔄 Build Details:
🚀 Environment Variables:
|
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## rc/barnard #7068 +/- ##
===========================================
Coverage 75.10% 75.10%
===========================================
Files 808 808
Lines 133617 133617
===========================================
+ Hits 100348 100359 +11
+ Misses 27578 27570 -8
+ Partials 5691 5688 -3 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
| git commit -m "Update Index of Reports" || echo "No changes to commit." | ||
| git push origin gh-pages --force |
There was a problem hiding this comment.
i think in the end status code will be taken from next command git push ...
elvisboghiu
dismissed stale reviews from andreibancioiu and sstanculeanu
via
699f0f1
| git commit -m "Update Index of Reports" || echo "No changes to commit." | ||
| if git commit -m "Update Index of Reports"; then | ||
| git push origin gh-pages --force | ||
| else |
|
❌ Integration Tests completed with failures or errors. 📊 MultiversX Automated Test Report: View Report 🔄 Build Details:
🚀 Environment Variables:
|
|
❌ Integration Tests completed with failures or errors. 📊 MultiversX Automated Test Report: View Report 🔄 Build Details:
🚀 Environment Variables:
|
|
❌ Integration Tests completed with failures or errors. 📊 MultiversX Automated Test Report: View Report 🔄 Build Details:
🚀 Environment Variables:
|
fix re-run passed tests to not fail the ci add file cleanup after execution
btc-fan
dismissed stale reviews from andreibancioiu, ssd04, and sstanculeanu
via
6262f96
|
Run Tests: |
|
❌ Integration Tests completed with failures or errors. 📊 MultiversX Automated Test Report: View Report 🔄 Build Details:
🚀 Environment Variables:
|
|
Run Tests: |
|
📊 MultiversX Automated Test Report: View Report 🔄 Build Details:
🚀 Environment Variables:
|
|
✅ Integration Tests passed successfully! 📊 MultiversX Automated Test Report: View Report 🔄 Build Details:
🚀 Environment Variables:
|
btc-fan
requested review from
AdoAdoAdo,
andreibancioiu,
axenteoctavian,
miiu96,
ssd04 and
sstanculeanu
.github/workflows/golangci-lint.yml
Outdated
| - uses: actions/setup-go@v5 | ||
| with: | ||
| go-version: 1.23.6 | ||
| cache: false |
There was a problem hiding this comment.
Only for self-hosted.
btc-fan
force-pushed
the
fix_gh_action_Update_Index_Page
branch
from
2605e72 to
0d9197a
Compare
There was a problem hiding this comment.
Pull Request Overview
This PR updates GitHub Actions workflows to improve the "Index of Reports" update and cleanup processes during CI runs. Key changes include:
- Disabling caching in the setup of Go actions across multiple workflows.
- Enhancing report parsing and the commit step for updating the index, with a safety check for when there are no changes to commit.
- Introducing a comprehensive cleanup block to terminate residual processes and remove temporary files post-test execution.
Reviewed Changes
Copilot reviewed 3 out of 3 changed files in this pull request and generated 2 comments.
| File | Description |
|---|---|
| .github/workflows/code-coverage.yml | Added “cache: false” to the Go setup step. |
| .github/workflows/build_and_test_on_macos.yml | Added “cache: false” to the Go setup step. |
| .github/workflows/build_and_run_chain_simulator_and_execute_system_test.yml | Updated test report parsing, refined the commit step, and added an extensive workspace cleanup process. |
| if git commit -m "Update Index of Reports"; then | ||
| git push origin gh-pages --force | ||
| else | ||
| echo "No changes to commit. Nothing to push." |
There was a problem hiding this comment.
[nitpick] Consider checking for changes before attempting to commit to avoid unnecessary commit attempts. Using a pre-check like 'git diff-index --quiet HEAD' can help ensure a commit is only attempted when there are changes.
| if git commit -m "Update Index of Reports"; then | |
| git push origin gh-pages --force | |
| else | |
| echo "No changes to commit. Nothing to push." | |
| if git diff-index --quiet HEAD; then | |
| echo "No changes to commit. Nothing to push." | |
| else | |
| git commit -m "Update Index of Reports" | |
| git push origin gh-pages --force |
| fi | ||
| - name: Cleanup Workspace and Processes |
There was a problem hiding this comment.
[nitpick] The cleanup block is quite extensive; consider refactoring these steps into a separate script to improve readability and reusability.
|
✅ Integration Tests passed successfully! 📊 MultiversX Automated Test Report: View Report 🔄 Build Details:
🚀 Environment Variables:
|
|
✅ Integration Tests passed successfully! 📊 MultiversX Automated Test Report: View Report 🔄 Build Details:
🚀 Environment Variables:
|
|
✅ Integration Tests passed successfully! 📊 MultiversX Automated Test Report: View Report 🔄 Build Details:
🚀 Environment Variables:
|
|
✅ Integration Tests passed successfully! 📊 MultiversX Automated Test Report: View Report 🔄 Build Details:
🚀 Environment Variables:
|
Reasoning behind the pull request
Proposed changes
Testing procedure
Pre-requisites
Based on the Contributing Guidelines the PR author and the reviewers must check the following requirements are met:
featbranch created?featbranch merging, do all satellite projects have a proper tag insidego.mod?