Skip to content

Conversation

@andreibancioiu
Copy link
Contributor

@andreibancioiu andreibancioiu commented Jun 12, 2025

Reasoning behind the pull request

  • Chain simulator tests workflow takes some time to complete.
  • Codecov workflow fails sometimes (unexpected errors).

Proposed changes

  • Move some long-running / often-failing workflows to self-hosted runners.

Testing procedure

  • No testing needed.

Pre-requisites

Based on the Contributing Guidelines the PR author and the reviewers must check the following requirements are met:

  • was the PR targeted to the correct branch?
  • if this is a larger feature that probably needs more than one PR, is there a feat branch created?
  • if this is a feat branch merging, do all satellite projects have a proper tag inside go.mod?

@andreibancioiu andreibancioiu self-assigned this Jun 12, 2025
@andreibancioiu andreibancioiu requested a review from Copilot June 12, 2025 12:16
Copy link
Contributor

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull Request Overview

This PR optimizes CI workflows by replacing the Ubuntu GitHub-hosted runner matrix with a self-hosted Linux x64 runner.

  • Jobs no longer use a matrix strategy targeting ubuntu-latest.
  • All build and test jobs now run on [self-hosted, Linux, X64].

Reviewed Changes

Copilot reviewed 2 out of 2 changed files in this pull request and generated no comments.

File Description
.github/workflows/code-coverage.yml Removed matrix strategy and set runs-on to the self-hosted runner.
.github/workflows/build_and_run_chain_simulator_and_execute_system_test.yml Same update for the chain simulator system test workflow.
Comments suppressed due to low confidence (2)

.github/workflows/code-coverage.yml:14

  • Runner labels on GitHub Actions are case-sensitive. Ensure the self-hosted runner has labels exactly matching 'Linux' and 'X64', or switch to the more common lowercase 'linux' and 'x64'.
runs-on: [self-hosted, Linux, X64]

.github/workflows/build_and_run_chain_simulator_and_execute_system_test.yml:25

  • Runner labels on GitHub Actions are case-sensitive. Ensure the self-hosted runner has labels exactly matching 'Linux' and 'X64', or switch to the more common lowercase 'linux' and 'x64'.
runs-on: [self-hosted, Linux, X64]

@codecov
Copy link

codecov bot commented Jun 12, 2025

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 70.13%. Comparing base (5d3cdc1) to head (6ee726a).
Report is 3 commits behind head on rc/barnard.

Additional details and impacted files
@@              Coverage Diff               @@
##           rc/barnard    #7046      +/-   ##
==============================================
- Coverage       70.14%   70.13%   -0.01%     
==============================================
  Files             942      942              
  Lines          146428   146428              
==============================================
- Hits           102709   102702       -7     
- Misses          37939    37945       +6     
- Partials         5780     5781       +1     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@github-actions
Copy link

📊 MultiversX Automated Test Report: View Report

🔄 Build Details:

  • mx-chain-go Commit Hash: f30a42065a3904bd7025c79182cae2701e6a9c7d
  • Current Branch: optimize-workflows-06-12
  • mx-chain-go Target Branch: rc/barnard
  • mx-chain-simulator-go Target Branch: rc/barnard
  • mx-chain-testing-suite Target Branch: rc/barnard

🚀 Environment Variables:

  • TIMESTAMP: 12062025-125408
  • PYTEST_EXIT_CODE: 0
    🎉 MultiversX CI/CD Workflow Complete!

@andreibancioiu andreibancioiu marked this pull request as ready for review June 13, 2025 06:42
@github-actions
Copy link

📊 MultiversX Automated Test Report: View Report

🔄 Build Details:

  • mx-chain-go Commit Hash: 6ee726ad6031306699527423efb4bde767899912
  • Current Branch: optimize-workflows-06-12
  • mx-chain-go Target Branch: rc/barnard
  • mx-chain-simulator-go Target Branch: rc/barnard
  • mx-chain-testing-suite Target Branch: rc/barnard

🚀 Environment Variables:

  • TIMESTAMP: 13062025-090928
  • PYTEST_EXIT_CODE: 0
    🎉 MultiversX CI/CD Workflow Complete!

@sstanculeanu sstanculeanu merged commit 96719dc into rc/barnard Jun 13, 2025
14 checks passed
@sstanculeanu sstanculeanu deleted the optimize-workflows-06-12 branch June 13, 2025 10:45
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants