Adjust workflow - optimization, plus migration on-prem (for MacOS) #7039
Conversation
![github-advanced-security[bot]](https://avatars.githubusercontent.com/in/57789?s=60&v=4){kind=small}
…in permissions Co-authored-by: Copilot Autofix powered by AI <62310815+github-advanced-security[bot]@users.noreply.github.com>
There was a problem hiding this comment.
Pull Request Overview
This PR optimizes the GitHub workflow by switching to an on-prem runner for MacOS short tests and removing the redundant Ubuntu build test.
- Updated the workflow name and added explicit permissions.
- Changed the runner configuration from a matrix-based approach (ubuntu/macos) to a fixed list of self-hosted labels.
- Removed the OS-specific conditional around running short tests.
| contents: read | ||
|
|
||
| jobs: | ||
| build: |
There was a problem hiding this comment.
Verify that the new runner labels [self-hosted, macOS, ARM64] correctly match the intended on-prem runner configuration. Consider adding a comment to explain the label selection for clearer future maintenance.
| build: | |
| build: | |
| # The workflow runs on a self-hosted macOS ARM64 runner. Ensure that the runner configuration matches these labels. |
| # On GitHub, we only run the short tests. | ||
| - name: Run tests | ||
| run: | | ||
| GOOS=$(go env GOOS) | ||
| if [[ "$GOOS" == darwin ]]; then | ||
| go test -short -v ./... | ||
| fi | ||
| go test -short -v ./... |
There was a problem hiding this comment.
Since the conditional check for GOOS has been removed, confirm that running the tests unconditionally is intended for the on-prem MacOS environment. Removing obsolete conditional logic improves clarity.
There was a problem hiding this comment.
Indeed, intended 🫡
| @@ -1,16 +1,16 @@ | |||
| name: Build and smoke test | |||
| name: Build and smoke test (on MacOS) | |||
There was a problem hiding this comment.
maybe rename to indicate also that we run short tests?
|
📊 MultiversX Automated Test Report: View Report 🔄 Build Details:
🚀 Environment Variables:
|
|
📊 MultiversX Automated Test Report: View Report 🔄 Build Details:
🚀 Environment Variables:
|
|
📊 MultiversX Automated Test Report: View Report 🔄 Build Details:
🚀 Environment Variables:
|
|
📊 MultiversX Automated Test Report: View Report 🔄 Build Details:
🚀 Environment Variables:
|
Reasoning behind the pull request
Proposed changes
Testing procedure
Pre-requisites
Based on the Contributing Guidelines the PR author and the reviewers must check the following requirements are met:
featbranch created?featbranch merging, do all satellite projects have a proper tag insidego.mod?