Fix hardware requirement cpu flags check

cmd/node/hardwareRequirements.go

@@ -0,0 +1,36 @@
+package main
+
+import (
+	"fmt"
+
+	"github.com/klauspost/cpuid/v2"
+	"github.com/multiversx/mx-chain-go/config"
+)
+
+func checkHardwareRequirements(cfg config.HardwareRequirementsConfig) error {
+	cpuFlags, err := parseFeatures(cfg.CPUFlags)
+	if err != nil {
+		return err
+	}
+
+	if !cpuid.CPU.Supports(cpuFlags...) {
+		return fmt.Errorf("CPU Flags: Streaming SIMD Extensions 4 required")
+	}
+
+	return nil
+}
+
+func parseFeatures(features []string) ([]cpuid.FeatureID, error) {
+	flags := make([]cpuid.FeatureID, 0)
+
+	for _, cpuFlag := range features {
+		featureID := cpuid.ParseFeature(cpuFlag)
+		if featureID == cpuid.UNKNOWN {
+			return nil, fmt.Errorf("CPU Flags: cpu flag %s not found", cpuFlag)
+		}
+
+		flags = append(flags, featureID)
+	}
+
+	return flags, nil
+}

cmd/node/hardwareRequirements_test.go

@@ -0,0 +1,54 @@
+package main
+
+import (
+	"testing"
+
+	"github.com/klauspost/cpuid/v2"
+	"github.com/stretchr/testify/require"
+)
+
+func TestParseFeatures(t *testing.T) {
+	t.Parallel()
+
+	t.Run("unknown feature id should fail", func(t *testing.T) {
+		t.Parallel()
+
+		features := []string{
+			cpuid.FeatureID(cpuid.UNKNOWN).String(),
+		}
+
+		retFeatures, err := parseFeatures(features)
+		require.Nil(t, retFeatures)
+		require.Error(t, err)
+	})
+
+	t.Run("non existing flag should fail", func(t *testing.T) {
+		t.Parallel()
+
+		features := []string{
+			"non existing feature id",
+		}
+
+		retFeatures, err := parseFeatures(features)
+		require.Nil(t, retFeatures)
+		require.Error(t, err)
+	})
+
+	t.Run("should work", func(t *testing.T) {
+		t.Parallel()
+
+		features := []string{
+			cpuid.FeatureID(cpuid.SSE).String(),
+			cpuid.FeatureID(cpuid.SSE2).String(),
+		}
+		retFeatures, err := parseFeatures(features)
+		require.Nil(t, err)
+
+		expFeatures := []cpuid.FeatureID{
+			cpuid.SSE,
+			cpuid.SSE2,
+		}
+
+		require.Equal(t, expFeatures, retFeatures)
+	})
+}

cmd/node/main.go

@@ -6,7 +6,6 @@ import (
 	"runtime"
 	"time"
 
-	"github.com/klauspost/cpuid/v2"
 	"github.com/multiversx/mx-chain-core-go/core"
 	"github.com/multiversx/mx-chain-core-go/core/check"
 	"github.com/multiversx/mx-chain-go/cmd/node/factory"
@@ -320,29 +319,3 @@ func attachFileLogger(log logger.Logger, flagsConfig *config.ContextFlagsConfig)
 
 	return fileLogging, nil
 }
-
-func checkHardwareRequirements(cfg config.HardwareRequirementsConfig) error {
-	cpuFlags, err := parseFeatures(cfg.CPUFlags)
-	if err != nil {
-		return err
-	}
-
-	if !cpuid.CPU.Supports(cpuFlags...) {
-		return fmt.Errorf("CPU Flags: Streaming SIMD Extensions 4 required")
-	}
-
-	return nil
-}
-
-func parseFeatures(features []string) ([]cpuid.FeatureID, error) {
-	flags := make([]cpuid.FeatureID, 0)
-
-	for _, cpuFlag := range features {
-		featureID := cpuid.ParseFeature(cpuFlag)
-		if featureID == cpuid.UNKNOWN {
-			return nil, fmt.Errorf("CPU Flags: cpu flag %s not found", cpuFlag)
-		}
-	}
-
-	return flags, nil
-}