Update smart contract hooks to export milliseconds #7025
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ssd04
commented
Jun 3, 2025
| // LastTimeStampMs returns the timeStamp in milliseconds from the last committed block | ||
| func (bh *BlockChainHookImpl) LastTimeStampMs() uint64 { | ||
| if !check.IfNil(bh.blockChain.GetCurrentBlockHeader()) { | ||
| return common.ConvertTimeStampSecToMs(bh.blockChain.GetCurrentBlockHeader().GetTimeStamp()) |
Contributor
Author
There was a problem hiding this comment.
ConvertTimeStampSecToMs looks like this
// ConvertTimeStampSecToMs will convert unix timestamp from seconds to milliseconds
// TODO: this has to be handled properly when round timestamp granularity will be changed to milliseconds
func ConvertTimeStampSecToMs(timeStamp uint64) uint64 {
return timeStamp * 1000
}
With Supernova we'll handle this TODO properly and change in all places
sstanculeanu
previously approved these changes
Jun 3, 2025
sasurobert
approved these changes
Jun 10, 2025
AdoAdoAdo
approved these changes
Jun 10, 2025
| defer bh.mutEpochStartHdr.RUnlock() | ||
|
|
||
| return bh.epochStartHdr.GetTimeStamp() | ||
| timestampMs := common.ConvertTimeStampSecToMs(bh.epochStartHdr.GetTimeStamp()) |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Reasoning behind the pull request
Testing procedure
Related PRs:
Pre-requisites
Based on the Contributing Guidelines the PR author and the reviewers must check the following requirements are met:
featbranch created?featbranch merging, do all satellite projects have a proper tag insidego.mod?