unit tests for merging same account accesses #6965
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| c.AddStateAccess(&data.StateAccess{ | ||
| Type: data.Write, | ||
| TxHash: []byte("hash"), | ||
| MainTrieKey: []byte(strconv.Itoa(0)), |
There was a problem hiding this comment.
Better use []byte("account1") or something like this instead of []byte(strconv.Itoa(0)). It is more readable. Change in all these tests. Use []byte(strconv.Itoa(i)) only if you add state accesses from a loop
| TxHash: []byte("hash"), | ||
| MainTrieKey: []byte(strconv.Itoa(1)), | ||
| MainTrieVal: []byte("mainTrieVal1"), | ||
| AccountChanges: &data.AccountChanges{ |
There was a problem hiding this comment.
Can extract this in a variable and use that variable on L588 when you check that the same account change was returned.
| TxHash: []byte("txHash"), | ||
| AccountChanges: defaultAccChanges, | ||
| MainTrieVal: []byte(fmt.Sprintf("mainTrieVal%d", i)), | ||
| Operation: uint32(math.Pow(2, float64(i%6))), |
There was a problem hiding this comment.
declare a slice like
operations := []uint32{
data.NotSet,
data.GetCode,
data.SaveAccount,
data.GetAccount,
data.WriteCode,
data.RemoveDataTrie,
data.GetDataTrieValue,
}
and use operations[i%len(operations)] here. It is more clear this way.
BeniaminDrasovean
approved these changes
Apr 29, 2025
BeniaminDrasovean
merged commit cd42a94
into
merge-same-account-accessess
2 checks passed
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Reasoning behind the pull request
Proposed changes
Testing procedure
Pre-requisites
Based on the Contributing Guidelines the PR author and the reviewers must check the following requirements are met:
featbranch created?featbranch merging, do all satellite projects have a proper tag insidego.mod?