Skip to content

Conversation

@AdoAdoAdo
Copy link
Contributor

@AdoAdoAdo AdoAdoAdo commented Mar 31, 2025

Reasoning behind the pull request

  • Remove unnecessary propagation of equivalent consensus proofs

Proposed changes

  • Avoid propagating own proofs when another proof already received and propagated

Testing procedure

  • regular system test & network bandwidth consumption checks

Pre-requisites

Based on the Contributing Guidelines the PR author and the reviewers must check the following requirements are met:

  • was the PR targeted to the correct branch?
  • if this is a larger feature that probably needs more than one PR, is there a feat branch created?
  • if this is a feat branch merging, do all satellite projects have a proper tag inside go.mod?

@AdoAdoAdo AdoAdoAdo changed the base branch from rc/andromeda to feat/andromeda-patch1 March 31, 2025 10:39
@AdoAdoAdo AdoAdoAdo marked this pull request as ready for review March 31, 2025 10:39
@github-actions
Copy link

📊 MultiversX Automated Test Report: View Report

🔄 Build Details:

  • mx-chain-go Commit Hash: 3b1f463a837d265ba40eb58f9a6c21b033766b9a
  • Current Branch: check-proof-existance-before-sending
  • mx-chain-go Target Branch: rc/andromeda
  • mx-chain-simulator-go Target Branch: rc/andromeda
  • mx-chain-testing-suite Target Branch: rc/andromeda

🚀 Environment Variables:

  • TIMESTAMP: 31032025-105702
  • PYTEST_EXIT_CODE: 0
    🎉 MultiversX CI/CD Workflow Complete!

sstanculeanu
sstanculeanu previously approved these changes Mar 31, 2025
@github-actions
Copy link

📊 MultiversX Automated Test Report: View Report

🔄 Build Details:

  • mx-chain-go Commit Hash: ae50304658024f88c96feaf6f44ecc4799016b0e
  • Current Branch: check-proof-existance-before-sending
  • mx-chain-go Target Branch: rc/andromeda
  • mx-chain-simulator-go Target Branch: rc/andromeda
  • mx-chain-testing-suite Target Branch: rc/andromeda

🚀 Environment Variables:

  • TIMESTAMP: 31032025-114928
  • PYTEST_EXIT_CODE: 0
    🎉 MultiversX CI/CD Workflow Complete!

@AdoAdoAdo AdoAdoAdo changed the title don't send proof if it was received Equivalent proofs propagation optimisation Apr 1, 2025
@AdoAdoAdo AdoAdoAdo merged commit 4467869 into feat/andromeda-patch1 Apr 1, 2025
4 checks passed
@AdoAdoAdo AdoAdoAdo deleted the check-proof-existance-before-sending branch April 1, 2025 12:21
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants