Fix bitmap #6921
Merged
Fix bitmap #6921
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
📊 MultiversX Automated Test Report: View Report 🔄 Build Details:
🚀 Environment Variables:
|
|
📊 MultiversX Automated Test Report: View Report 🔄 Build Details:
🚀 Environment Variables:
|
|
📊 MultiversX Automated Test Report: View Report 🔄 Build Details:
🚀 Environment Variables:
|
|
📊 MultiversX Automated Test Report: View Report 🔄 Build Details:
🚀 Environment Variables:
|
|
📊 MultiversX Automated Test Report: View Report 🔄 Build Details:
🚀 Environment Variables:
|
sstanculeanu
reviewed
Apr 1, 2025
| return result | ||
| } | ||
|
|
||
| func UnsetBitInBitmap(index int, bitmap []byte) error { |
There was a problem hiding this comment.
Pull Request Overview
This PR addresses a bug fix in the bitmap generation and update logic used in block processing and associated testing. Key changes include:
- Updating tests in processor_test.go to cover the UnsetBitInBitmap functionality.
- Modifying the CreateNewBlock and updatePreviousProofAndAddonHeader flows in processor.go to invoke UnsetBitInBitmap for non-managed validators.
- Adjusting configuration parameters and timing in chainSimulator.go and jail_test.go to better reflect the desired simulator behavior.
Reviewed Changes
Copilot reviewed 4 out of 4 changed files in this pull request and generated 1 comment.
| File | Description |
|---|---|
| node/chainSimulator/process/processor_test.go | Added tests to check bitmap manipulation functions |
| node/chainSimulator/process/processor.go | Updated bitmap handling in block creation and signature logic |
| node/chainSimulator/chainSimulator.go | Changed consensus configuration and increased sleep duration |
| integrationTests/chainSimulator/staking/jail/jail_test.go | Increased epoch transitions to simulate multi-epoch behavior |
Comments suppressed due to low confidence (1)
node/chainSimulator/process/processor.go:317
- [nitpick] Replacing header.GetPubKeysBitmap() with a hardcoded []byte{1} might not be intended; please verify that this change correctly reflects the intended signature behavior.
[]byte{1},
| } | ||
|
|
||
| func UnsetBitInBitmap(index int, bitmap []byte) error { | ||
| if len(bitmap) < index/8 { |
There was a problem hiding this comment.
The boundary check in UnsetBitInBitmap may be off by one; consider using 'if index/8 >= len(bitmap)' to correctly validate the bitmap length.
Suggested change
| if len(bitmap) < index/8 { | |
| if index/8 >= len(bitmap) { |
ssd04
reviewed
Apr 1, 2025
| } | ||
|
|
||
| func UnsetBitInBitmap(index int, bitmap []byte) error { | ||
| if len(bitmap) < index/8 { |
There was a problem hiding this comment.
if index%8 is not 0, i think expected bitmap size has to be higher
|
|
||
| func UnsetBitInBitmap(index int, bitmap []byte) error { | ||
| if len(bitmap) < index/8 { | ||
| return errors.New("bitmap too short") |
There was a problem hiding this comment.
we already have ErrWrongSizeBitmap is errors/common
| headerHash, | ||
| header.GetEpoch(), | ||
| header.GetPubKeysBitmap(), | ||
| []byte{1}, |
|
📊 MultiversX Automated Test Report: View Report 🔄 Build Details:
🚀 Environment Variables:
|
ssd04
approved these changes
Apr 1, 2025
sstanculeanu
approved these changes
Apr 1, 2025
|
📊 MultiversX Automated Test Report: View Report 🔄 Build Details:
🚀 Environment Variables:
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Reasoning behind the pull request
Pre-requisites
Based on the Contributing Guidelines the PR author and the reviewers must check the following requirements are met:
featbranch created?featbranch merging, do all satellite projects have a proper tag insidego.mod?