Proofs pool upsert #6887
Merged
Proofs pool upsert #6887
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| } | ||
|
|
||
| // AddProof will add the provided proof to the pool, if it's not already in the pool. | ||
| // It will return true if the proof the was added to the pool. |
Collaborator
There was a problem hiding this comment.
Suggested change
| // It will return true if the proof the was added to the pool. | |
| // It will return true if the proof was added to the pool. |
| if check.IfNil(argument.ValidityAttester) { | ||
| return nil, process.ErrNilValidityAttester | ||
| } | ||
| if check.IfNil(argument.ProofsPool) { |
Collaborator
There was a problem hiding this comment.
not need, it is only forwarded to the component
AdoAdoAdo
reviewed
Mar 18, 2025
| func (pp *proofsPool) UpsertProof( | ||
| headerProof data.HeaderProofHandler, | ||
| ) bool { | ||
| if check.IfNilReflect(headerProof) { |
Contributor
There was a problem hiding this comment.
check.IfNil instead for proofs IsInterfaceNil was added for the HeaderProofHandler
|
|
||
| // IsProofInPoolEqualTo will check if the provided proof is equal with the already existing proof in the pool | ||
| func (pp *proofsPool) IsProofInPoolEqualTo(headerProof data.HeaderProofHandler) bool { | ||
| if check.IfNilReflect(headerProof) { |
| if common.ShouldBlockHavePrevProof(interceptedHdr.HeaderHandler(), hip.enableEpochsHandler, common.EquivalentMessagesFlag) { | ||
| ok = hip.proofs.AddProof(interceptedHdr.HeaderHandler().GetPreviousProof()) | ||
| log.Trace("HdrInterceptorProcessor.AddProof: add previous proof", "intercepted header hash", interceptedHdr.Hash(), "added", ok) | ||
| ok = hip.proofs.UpsertProof(interceptedHdr.HeaderHandler().GetPreviousProof()) |
Contributor
There was a problem hiding this comment.
I think we can remove this one, and update to upsert the one in VerifyHeaderWithProof
also it could be removed also from saveProofForPreviousHeaderIfNeeded as it should have already added on verifyHeaderWithProof
Contributor
Author
There was a problem hiding this comment.
removed duplicated add prev proofs
| // NewInterceptedMetaHeaderDataFactory creates an instance of interceptedMetaHeaderDataFactory | ||
| func NewInterceptedMetaHeaderDataFactory(argument *ArgInterceptedDataFactory) (*interceptedMetaHeaderDataFactory, error) { | ||
| func NewInterceptedMetaHeaderDataFactory(argument *ArgInterceptedMetaHeaderFactory) (*interceptedMetaHeaderDataFactory, error) { | ||
| if argument == nil { |
Contributor
There was a problem hiding this comment.
check for not nil proofs pool?
sstanculeanu
approved these changes
Mar 18, 2025
AdoAdoAdo
approved these changes
Mar 19, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Reasoning behind the pull request
Upsert,IsProofInPoolEqualToTesting procedure
Pre-requisites
Based on the Contributing Guidelines the PR author and the reviewers must check the following requirements are met:
featbranch created?featbranch merging, do all satellite projects have a proper tag insidego.mod?