Integration test rewards Andromeda #6875
Conversation
| defaultPathToInitialConfig = "../../../cmd/node/config/" | ||
| ) | ||
|
|
||
| func TestRewardsTxsAfterEquivalentMessages(t *testing.T) { |
There was a problem hiding this comment.
should we consider this a long test as well?
| ApiInterface: api.NewNoApiInterface(), | ||
| MinNodesPerShard: 3, | ||
| MetaChainMinNodes: 3, | ||
| AlterConfigsFunction: func(cfg *config.Configs) { |
| for i := 0; i < targetEpoch; i++ { | ||
| if i == 8 { | ||
| fmt.Println("here") | ||
| } | ||
| err = cs.ForceChangeOfEpoch() | ||
| require.Nil(t, err) | ||
| } | ||
|
|
||
| err = cs.GenerateBlocks(210) | ||
| require.Nil(t, err) |
There was a problem hiding this comment.
is this needed? or GenerateBlocksUntilEpochIsReached can be used?
There was a problem hiding this comment.
If I use that function, more blocks will be generated until I reach epoch 9, with this method, only 30 blocks are generated.
There was a problem hiding this comment.
maybe remove
if i == 8 {
fmt.Println("here")
}| nodesSetupFile := path.Join(tempDir, "config", "nodesSetup.json") | ||
| validators, err := readValidatorsAndOwners(nodesSetupFile) | ||
| require.Nil(t, err) | ||
| fmt.Println(validators) |
| rewardsPerShard[shardID] = big.NewInt(0) | ||
| } | ||
|
|
||
| valueBig, okR := rewardsPerShard[shardID].SetString(tx.Value, 10) |
There was a problem hiding this comment.
| valueBig, okR := rewardsPerShard[shardID].SetString(tx.Value, 10) | |
| valueBig, okR := big.NewInt(0).SetString(tx.Value, 10) |
There was a problem hiding this comment.
otherwise it will also set rewardsPerShard[shardID]
| } | ||
|
|
||
| func allValuesEqual(m map[uint32]*big.Int) bool { | ||
| var firstValue *big.Int |
There was a problem hiding this comment.
can use m[0] as expectedValue instead of these 2 variables
| } | ||
|
|
||
| func (s *simulator) addProofs() { | ||
| proofs := make([]*block.HeaderProof, 0) |
There was a problem hiding this comment.
| proofs := make([]*block.HeaderProof, 0) | |
| proofs := make([]*block.HeaderProof, 0, len(s.nodes)) |
| } | ||
|
|
||
| for _, proof := range proofs { | ||
| s.GetNodeHandler(core.MetachainShardId).GetDataComponents().Datapool().Proofs().AddProof(proof) |
There was a problem hiding this comment.
extract s.GetNodeHandler(core.MetachainShardId).GetDataComponents().Datapool().Proofs() outside of the for loop
| for i := 0; i < targetEpoch; i++ { | ||
| if i == 8 { | ||
| fmt.Println("here") | ||
| } | ||
| err = cs.ForceChangeOfEpoch() | ||
| require.Nil(t, err) | ||
| } | ||
|
|
||
| err = cs.GenerateBlocks(210) | ||
| require.Nil(t, err) |
There was a problem hiding this comment.
maybe remove
if i == 8 {
fmt.Println("here")
}| func allValuesEqual(m map[uint32]*big.Int) bool { | ||
| if len(m) == 0 { | ||
| return true | ||
| } | ||
|
|
||
| var firstValue *big.Int | ||
| for _, v := range m { | ||
| if firstValue == nil { | ||
| firstValue = v | ||
| continue | ||
| } | ||
| if firstValue.Cmp(v) != 0 { | ||
| return false | ||
| } | ||
| } | ||
| return true | ||
| } |
There was a problem hiding this comment.
| func allValuesEqual(m map[uint32]*big.Int) bool { | |
| if len(m) == 0 { | |
| return true | |
| } | |
| var firstValue *big.Int | |
| for _, v := range m { | |
| if firstValue == nil { | |
| firstValue = v | |
| continue | |
| } | |
| if firstValue.Cmp(v) != 0 { | |
| return false | |
| } | |
| } | |
| return true | |
| } | |
| func allValuesEqual(m map[uint32]*big.Int) bool { | |
| if len(m) == 0 { | |
| return true | |
| } | |
| expectedValue := m[0] | |
| for _, v := range m { | |
| if expectedValue.Cmp(v) != 0 { | |
| return false | |
| } | |
| } | |
| return true | |
| } |
this was my initial suggestion, assuming we always have a shard 0
Reasoning behind the pull request
Pre-requisites
Based on the Contributing Guidelines the PR author and the reviewers must check the following requirements are met:
featbranch created?featbranch merging, do all satellite projects have a proper tag insidego.mod?