Skip to content

Conversation

@laurci
Copy link
Contributor

@laurci laurci commented Mar 4, 2025

Reasoning behind the pull request

  • Integrate new version of VM with the new transfer and execute and return error hook.

Related PRs

Pre-requisites

Based on the Contributing Guidelines the PR author and the reviewers must check the following requirements are met:

  • was the PR targeted to the correct branch?
  • if this is a larger feature that probably needs more than one PR, is there a feat branch created?
  • if this is a feat branch merging, do all satellite projects have a proper tag inside go.mod?

@laurci laurci changed the title update vm version integrate transfer and execute with return error Mar 4, 2025
@github-actions
Copy link

github-actions bot commented Mar 4, 2025

📊 MultiversX Automated Test Report: View Report

🔄 Build Details:

  • mx-chain-go Commit Hash: aacd0ff50a22d9f78c01d8adf23d341a4eabef37
  • Current Branch: transfer-with-return-err
  • mx-chain-go Target Branch: rc/barnard
  • mx-chain-simulator-go Target Branch: rc/barnard
  • mx-chain-testing-suite Target Branch: rc/barnard

🚀 Environment Variables:

  • TIMESTAMP: 04032025-115449
  • PYTEST_EXIT_CODE: 1
    🎉 MultiversX CI/CD Workflow Complete!

sstanculeanu
sstanculeanu previously approved these changes Mar 4, 2025
@github-actions
Copy link

github-actions bot commented Mar 4, 2025

📊 MultiversX Automated Test Report: View Report

🔄 Build Details:

  • mx-chain-go Commit Hash: ae061b7147052f7e7508cdadc1d6d94fa38e9923
  • Current Branch: transfer-with-return-err
  • mx-chain-go Target Branch: rc/barnard
  • mx-chain-simulator-go Target Branch: rc/barnard
  • mx-chain-testing-suite Target Branch: rc/barnard

🚀 Environment Variables:

  • TIMESTAMP: 04032025-121427
  • PYTEST_EXIT_CODE: 0
    🎉 MultiversX CI/CD Workflow Complete!

danidrasovean
danidrasovean previously approved these changes Mar 5, 2025
Copy link
Contributor

@danidrasovean danidrasovean left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Normal allin test: master-37ab7adf91 -> transfer-with-return-err-ae061b7147

--- Specific errors ---

block hash does not match 10
wrong nonce in block 35
miniblocks does not match 0
num miniblocks does not match 0
miniblock hash does not match 0
block bodies does not match 0
receipts hash missmatch 0

/------/

--- Statistics ---

Nr. of all ERRORS: 9
Nr. of all WARNS: 318
Nr. of new ERRORS: 9
Nr. of new WARNS: 78

/------/

--- System test go ---

All scenarios from system-test-go are OK!
/------/

@laurci laurci dismissed stale reviews from danidrasovean and sstanculeanu via 16f0269 March 6, 2025 10:42
@multiversx multiversx deleted a comment from github-actions bot Mar 6, 2025
@multiversx multiversx deleted a comment from github-actions bot Mar 6, 2025
@multiversx multiversx deleted a comment from github-actions bot Mar 6, 2025
@multiversx multiversx deleted a comment from github-actions bot Mar 6, 2025
@multiversx multiversx deleted a comment from github-actions bot Mar 6, 2025
@github-actions
Copy link

github-actions bot commented Mar 6, 2025

📊 MultiversX Automated Test Report: View Report

🔄 Build Details:

  • mx-chain-go Commit Hash: 16f0269bd36a51db8fab7800e4624b759f9da4a4
  • Current Branch: transfer-with-return-err
  • mx-chain-go Target Branch: rc/barnard
  • mx-chain-simulator-go Target Branch: rc/barnard
  • mx-chain-testing-suite Target Branch: rc/barnard

🚀 Environment Variables:

  • TIMESTAMP: 06032025-120239
  • PYTEST_EXIT_CODE: 0
    🎉 MultiversX CI/CD Workflow Complete!

@github-actions
Copy link

📊 MultiversX Automated Test Report: View Report

🔄 Build Details:

  • mx-chain-go Commit Hash: 252b04206be51d5229435aa6fbf4258989fe8f42
  • Current Branch: transfer-with-return-err
  • mx-chain-go Target Branch: rc/barnard
  • mx-chain-simulator-go Target Branch: rc/barnard
  • mx-chain-testing-suite Target Branch: rc/barnard

🚀 Environment Variables:

  • TIMESTAMP: 14032025-093414
  • PYTEST_EXIT_CODE: 0
    🎉 MultiversX CI/CD Workflow Complete!

Copy link
Contributor

@danidrasovean danidrasovean left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Normal allin test: master-37ab7adf91 -> transfer-with-return-err-252b04206b

--- Specific errors ---

block hash does not match 0
wrong nonce in block 49
miniblocks does not match 0
num miniblocks does not match 0
miniblock hash does not match 0
block bodies does not match 1
receipts hash missmatch 0

/------/

--- Statistics ---

Nr. of all ERRORS: 8
Nr. of all WARNS: 324
Nr. of new ERRORS: 8
Nr. of new WARNS: 55
Nr. of PANICS: 0

/------/

--- System test go ---

All scenarios from system-test-go are OK!
/------/

@github-actions
Copy link

📊 MultiversX Automated Test Report: View Report

🔄 Build Details:

  • mx-chain-go Commit Hash: c7cd98557fd9e3e0b0cf219f0067eef2c7deed59
  • Current Branch: transfer-with-return-err
  • mx-chain-go Target Branch: rc/barnard
  • mx-chain-simulator-go Target Branch: rc/barnard
  • mx-chain-testing-suite Target Branch: rc/barnard

🚀 Environment Variables:

  • TIMESTAMP: 17032025-124204
  • PYTEST_EXIT_CODE: 0
    🎉 MultiversX CI/CD Workflow Complete!

@laurci laurci merged commit fa63bff into rc/barnard Mar 18, 2025
8 checks passed
@laurci laurci deleted the transfer-with-return-err branch March 18, 2025 12:00
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants