Skip to content

vm integration for get all transfers value hook, get code hash hook and internal errors masking #6774

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 6 commits into from
Feb 10, 2025
Merged

vm integration for get all transfers value hook, get code hash hook and internal errors masking #6774

merged 6 commits into from
Feb 10, 2025

Conversation

@laurci
Copy link
Contributor

@laurci laurci commented Feb 4, 2025 •
edited
Loading

Proposed changes

  • Integrate new version of VM
  • Added new VM hook (managedGetAllTransfersCallValue)
  • Added new VM hook (managedGetCodeHash)
  • Masked errors from libraries (that should remain internal to the VM) with activation epoch

Related PRs:

Based on the Contributing Guidelines the PR author and the reviewers must check the following requirements are met:

  • was the PR targeted to the correct branch?
  • if this is a larger feature that probably needs more than one PR, is there a feat branch created?
  • if this is a feat branch merging, do all satellite projects have a proper tag inside go.mod?

@github-actions
Copy link

github-actions bot commented Feb 4, 2025

📊 MultiversX Automated Test Report: View Report

🔄 Build Details:

  • mx-chain-go Commit Hash: 32eb78d01d0cefca6b8c134e91c050b8ad9f2542
  • Current Branch: integration-vm-all-call-value-and-error-masking
  • mx-chain-go Target Branch: rc/barnard
  • mx-chain-simulator-go Target Branch: rc/barnard
  • mx-chain-testing-suite Target Branch: rc/barnard

🚀 Environment Variables:

  • TIMESTAMP: 04022025-111452
  • PYTEST_EXIT_CODE: 0
    🎉 MultiversX CI/CD Workflow Complete!

@github-actions
Copy link

github-actions bot commented Feb 4, 2025

📊 MultiversX Automated Test Report: View Report

🔄 Build Details:

  • mx-chain-go Commit Hash: b41d17070a80db9166496dd3b3b7de9e3c78dc2b
  • Current Branch: integration-vm-all-call-value-and-error-masking
  • mx-chain-go Target Branch: rc/barnard
  • mx-chain-simulator-go Target Branch: rc/barnard
  • mx-chain-testing-suite Target Branch: rc/barnard

🚀 Environment Variables:

  • TIMESTAMP: 04022025-144727
  • PYTEST_EXIT_CODE: 0
    🎉 MultiversX CI/CD Workflow Complete!

@laurci laurci changed the title vm integration for get all call value hook and internal errors masking vm integration for get all transfers value hook and internal errors masking Feb 4, 2025
sasurobert
sasurobert previously approved these changes Feb 5, 2025
View reviewed changes
@laurci laurci changed the title vm integration for get all transfers value hook and internal errors masking vm integration for get all transfers value hook, get code hash hook and internal errors masking Feb 5, 2025
@github-actions
Copy link

github-actions bot commented Feb 5, 2025

📊 MultiversX Automated Test Report: View Report

🔄 Build Details:

  • mx-chain-go Commit Hash: 7885fafc17a6dc9e736689d2cffbf465e47c9348
  • Current Branch: integration-vm-all-call-value-and-error-masking
  • mx-chain-go Target Branch: rc/barnard
  • mx-chain-simulator-go Target Branch: rc/barnard
  • mx-chain-testing-suite Target Branch: rc/barnard

🚀 Environment Variables:

  • TIMESTAMP: 05022025-131721
  • PYTEST_EXIT_CODE: 0
    🎉 MultiversX CI/CD Workflow Complete!

sasurobert
sasurobert previously approved these changes Feb 5, 2025
View reviewed changes
@github-actions
Copy link

github-actions bot commented Feb 6, 2025

📊 MultiversX Automated Test Report: View Report

🔄 Build Details:

  • mx-chain-go Commit Hash: a5e427ab8f2475b6dac79e95bc6f25d841bc52a1
  • Current Branch: integration-vm-all-call-value-and-error-masking
  • mx-chain-go Target Branch: rc/barnard
  • mx-chain-simulator-go Target Branch: rc/barnard
  • mx-chain-testing-suite Target Branch: rc/barnard

🚀 Environment Variables:

  • TIMESTAMP: 06022025-094746
  • PYTEST_EXIT_CODE: 0
    🎉 MultiversX CI/CD Workflow Complete!

sasurobert
sasurobert previously approved these changes Feb 6, 2025
View reviewed changes
danidrasovean
danidrasovean previously approved these changes Feb 6, 2025
View reviewed changes
Copy link
Contributor

@danidrasovean danidrasovean left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Normal allin test: v1.8.9-dev-config-373fab6fb9 -> integration-vm-all-call-va-a5e427ab8f

--- Specific errors ---

block hash does not match 441
wrong nonce in block 226
miniblocks does not match 0
num miniblocks does not match 0
miniblock hash does not match 0
block bodies does not match 0
receipts hash missmatch 0

/------/

--- Statistics ---

Nr. of all ERRORS: 8
Nr. of all WARNS: 4082
Nr. of new ERRORS: 8
Nr. of new WARNS: 3847

/------/

--- System test go ---

All scenarios from system-test-go are OK!
/------/

AdoAdoAdo
AdoAdoAdo reviewed Feb 7, 2025
View reviewed changes
cmd/node/config/enableEpochs.toml Outdated
RelayedTransactionsV3EnableEpoch = 1

# MaskVMInternalDependenciesErrorsEnableEpoch represents the epoch when the additional internal erorr masking in vm is enabled
MaskVMInternalDependenciesErrorsEnableEpoch = 10
Copy link
Contributor

@AdoAdoAdo AdoAdoAdo Feb 7, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

can we have this activated sooner ?
we have the maximum epoch for activation of the other flags as 4
if there is no other dependency I would set this to 4 as well or even earlier

Copy link
Contributor Author

@laurci laurci Feb 7, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

this was set for the system test (we had to do some manual testing before and after the activation epoch). before we ship barnard, this should be set to an epoch in the future.

@laurci laurci dismissed stale reviews from danidrasovean and sasurobert via db608bc February 10, 2025 08:21
@github-actions
Copy link

github-actions bot commented Feb 10, 2025

📊 MultiversX Automated Test Report: View Report

🔄 Build Details:

  • mx-chain-go Commit Hash: db608bc916ca01b68226943eef3de25892368036
  • Current Branch: integration-vm-all-call-value-and-error-masking
  • mx-chain-go Target Branch: rc/barnard
  • mx-chain-simulator-go Target Branch: rc/barnard
  • mx-chain-testing-suite Target Branch: rc/barnard

🚀 Environment Variables:

  • TIMESTAMP: 10022025-085022
  • PYTEST_EXIT_CODE: 0
    🎉 MultiversX CI/CD Workflow Complete!

@github-actions
Copy link

github-actions bot commented Feb 10, 2025

📊 MultiversX Automated Test Report: View Report

🔄 Build Details:

  • mx-chain-go Commit Hash: 256c857cfb777cdc01ec744e8462542d080aa1c2
  • Current Branch: integration-vm-all-call-value-and-error-masking
  • mx-chain-go Target Branch: rc/barnard
  • mx-chain-simulator-go Target Branch: rc/barnard
  • mx-chain-testing-suite Target Branch: rc/barnard

🚀 Environment Variables:

  • TIMESTAMP: 10022025-091322
  • PYTEST_EXIT_CODE: 0
    🎉 MultiversX CI/CD Workflow Complete!

@AdoAdoAdo AdoAdoAdo merged commit 749d4ca into rc/barnard Feb 10, 2025
8 checks passed
@AdoAdoAdo AdoAdoAdo deleted the integration-vm-all-call-value-and-error-masking branch February 10, 2025 09:27
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@sasurobert sasurobert sasurobert approved these changes

@AdoAdoAdo AdoAdoAdo AdoAdoAdo approved these changes

@danidrasovean danidrasovean danidrasovean approved these changes

Assignees

@laurci laurci

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

5 participants

@laurci @sasurobert @AdoAdoAdo @danidrasovean