Skip to content

Conversation

@AdoAdoAdo
Copy link
Contributor

@AdoAdoAdo AdoAdoAdo commented Jan 28, 2025

Reasoning behind the pull request

Implementation of Andromeda consensus described here: https://agora.multiversx.com/t/mip-25-removing-confirmation-blocks-andromeda/482 :

  • removes block equivocation reasons
  • removes forking reasons
  • increases consensus size to 400/400 for all shards

Integration of the Andromeda consensus:

  • removes confirmation blocks - due to all of the above, finality for all blocks becomes instant
  • fixed ordering in consensus group during an epoch

Proposed changes

  • The equivalent consensus proofs are introduced for removing equivocation on voted blocks
  • Increase consensus size for shards and adapt the rating and rewards accordingly - uniform handling on all shards
  • Consensus state machine changed to reflect the usage of equivalent consensus proofs, removed consensus header interceptor and switched to general header interceptor.
  • Propagation of the proposed block directly to all interested shards, as the block will no longer be changed through consensus
  • Epoch trigger, block tracker, fork detector, notarization and execution rules changed to support instant finality.
  • New topic/requesters/resolvers/interceptors/storage/pool for equivalent consensus proofs and introduced anti flood protections
  • Delayed block data propagation adapted for equivalent proofs and instant finality
  • Adapted node network sync, import DB sync, bootstrapping from DB

Testing procedure

  • chaos testing - with the chaos testing framework
  • load testing - txgen scenarios
  • performance testing & analysis vs Spica - performance analysis framework with record-replay txgen scenarios
  • chain simulator tests
  • shadow fork testing
  • full automated functional testing & system tests
  • backup machines testing
  • full history nodes tests
  • reset heavy test
  • upgrade test
  • backwards compatibility (importDB) tests
  • half network upgrade system test
  • rosetta checks

Pre-requisites

Based on the Contributing Guidelines the PR author and the reviewers must check the following requirements are met:

  • was the PR targeted to the correct branch?
  • if this is a larger feature that probably needs more than one PR, is there a feat branch created?
  • if this is a feat branch merging, do all satellite projects have a proper tag inside go.mod?

@github-actions
Copy link

📊 MultiversX Automated Test Report: View Report

🔄 Build Details:

  • mx-chain-go Commit Hash: cd30d49bdeff0e6d575a11db8c613c7168071c5c
  • Current Branch: rc/andromeda
  • mx-chain-go Target Branch: master
  • mx-chain-simulator-go Target Branch: main
  • mx-chain-testing-suite Target Branch: main

🚀 Environment Variables:

  • TIMESTAMP: 28012025-145550
  • PYTEST_EXIT_CODE: 0
    🎉 MultiversX CI/CD Workflow Complete!

@github-actions
Copy link

📊 MultiversX Automated Test Report: View Report

🔄 Build Details:

  • mx-chain-go Commit Hash: 7a398f1a829ffc8d3761d268cd38fb098d9404b5
  • Current Branch: rc/andromeda
  • mx-chain-go Target Branch: master
  • mx-chain-simulator-go Target Branch: main
  • mx-chain-testing-suite Target Branch: main

🚀 Environment Variables:

  • TIMESTAMP: 18022025-071730
  • PYTEST_EXIT_CODE: 0
    🎉 MultiversX CI/CD Workflow Complete!

@github-actions
Copy link

📊 MultiversX Automated Test Report: View Report

🔄 Build Details:

  • mx-chain-go Commit Hash: c5db0669dc3a7a90e07710d6ad4411ab542a356f
  • Current Branch: rc/andromeda
  • mx-chain-go Target Branch: master
  • mx-chain-simulator-go Target Branch: main
  • mx-chain-testing-suite Target Branch: main

🚀 Environment Variables:

  • TIMESTAMP: 21022025-131923
  • PYTEST_EXIT_CODE: 0
    🎉 MultiversX CI/CD Workflow Complete!

@github-actions
Copy link

📊 MultiversX Automated Test Report: View Report

🔄 Build Details:

  • mx-chain-go Commit Hash: 2214c830bd0c4a72781caa108f30db7a1c92d9ea
  • Current Branch: rc/andromeda
  • mx-chain-go Target Branch: master
  • mx-chain-simulator-go Target Branch: main
  • mx-chain-testing-suite Target Branch: main

🚀 Environment Variables:

  • TIMESTAMP: 21022025-160249
  • PYTEST_EXIT_CODE: 0
    🎉 MultiversX CI/CD Workflow Complete!

@github-actions
Copy link

📊 MultiversX Automated Test Report: View Report

🔄 Build Details:

  • mx-chain-go Commit Hash: 6c6fd2bb0174c49d107ae031c8512ec1f86db4b4
  • Current Branch: rc/andromeda
  • mx-chain-go Target Branch: master
  • mx-chain-simulator-go Target Branch: main
  • mx-chain-testing-suite Target Branch: main

🚀 Environment Variables:

  • TIMESTAMP: 18032025-163601
  • PYTEST_EXIT_CODE: 0
    🎉 MultiversX CI/CD Workflow Complete!

@github-actions
Copy link

📊 MultiversX Automated Test Report: View Report

🔄 Build Details:

  • mx-chain-go Commit Hash: 8a76c55f99384e5c26a34f4a5849178bd07d3ee3
  • Current Branch: rc/andromeda
  • mx-chain-go Target Branch: master
  • mx-chain-simulator-go Target Branch: main
  • mx-chain-testing-suite Target Branch: main

🚀 Environment Variables:

  • TIMESTAMP: 20032025-105500
  • PYTEST_EXIT_CODE: 0
    🎉 MultiversX CI/CD Workflow Complete!

@github-actions
Copy link

📊 MultiversX Automated Test Report: View Report

🔄 Build Details:

  • mx-chain-go Commit Hash: 02fe5eeb5e744d169f115416bd730e603d2b6815
  • Current Branch: rc/andromeda
  • mx-chain-go Target Branch: master
  • mx-chain-simulator-go Target Branch: main
  • mx-chain-testing-suite Target Branch: main

🚀 Environment Variables:

  • TIMESTAMP: 21032025-101303
  • PYTEST_EXIT_CODE: 0
    🎉 MultiversX CI/CD Workflow Complete!

@AdoAdoAdo AdoAdoAdo self-assigned this Mar 24, 2025
@github-actions
Copy link

📊 MultiversX Automated Test Report: View Report

🔄 Build Details:

  • mx-chain-go Commit Hash: 2fec7b3e3d11486ad69fd30e7972a5c743f5f52f
  • Current Branch: rc/andromeda
  • mx-chain-go Target Branch: master
  • mx-chain-simulator-go Target Branch: main
  • mx-chain-testing-suite Target Branch: main

🚀 Environment Variables:

  • TIMESTAMP: 24032025-172450
  • PYTEST_EXIT_CODE: 0
    🎉 MultiversX CI/CD Workflow Complete!

@github-actions
Copy link

📊 MultiversX Automated Test Report: View Report

🔄 Build Details:

  • mx-chain-go Commit Hash: 5c82ac121e181951de1d3050f2c34f2d15975940
  • Current Branch: rc/andromeda
  • mx-chain-go Target Branch: master
  • mx-chain-simulator-go Target Branch: main
  • mx-chain-testing-suite Target Branch: main

🚀 Environment Variables:

  • TIMESTAMP: 28032025-183658
  • PYTEST_EXIT_CODE: 0
    🎉 MultiversX CI/CD Workflow Complete!

@github-actions
Copy link

📊 MultiversX Automated Test Report: View Report

🔄 Build Details:

  • mx-chain-go Commit Hash: e40ced2df3a35b959c5a883d0bc09ef6e23e714b
  • Current Branch: rc/andromeda
  • mx-chain-go Target Branch: master
  • mx-chain-simulator-go Target Branch: main
  • mx-chain-testing-suite Target Branch: main

🚀 Environment Variables:

  • TIMESTAMP: 14052025-092023
  • PYTEST_EXIT_CODE: 0
    🎉 MultiversX CI/CD Workflow Complete!

@github-actions
Copy link

📊 MultiversX Automated Test Report: View Report

🔄 Build Details:

  • mx-chain-go Commit Hash: e0d255e46759d2349db92a80b56518025c8b9c75
  • Current Branch: rc/andromeda
  • mx-chain-go Target Branch: master
  • mx-chain-simulator-go Target Branch: main
  • mx-chain-testing-suite Target Branch: main

🚀 Environment Variables:

  • TIMESTAMP: 14052025-100454
  • PYTEST_EXIT_CODE: 0
    🎉 MultiversX CI/CD Workflow Complete!

@github-actions
Copy link

📊 MultiversX Automated Test Report: View Report

🔄 Build Details:

  • mx-chain-go Commit Hash: 24219b2ff87875e407bf9403eff4d322194f24cd
  • Current Branch: rc/andromeda
  • mx-chain-go Target Branch: master
  • mx-chain-simulator-go Target Branch: main
  • mx-chain-testing-suite Target Branch: main

🚀 Environment Variables:

  • TIMESTAMP: 15052025-111534
  • PYTEST_EXIT_CODE: 0
    🎉 MultiversX CI/CD Workflow Complete!

@github-actions
Copy link

📊 MultiversX Automated Test Report: View Report

🔄 Build Details:

  • mx-chain-go Commit Hash: 9f2444e9236026ad87bf8d77ec7e496e8e515c42
  • Current Branch: rc/andromeda
  • mx-chain-go Target Branch: master
  • mx-chain-simulator-go Target Branch: main
  • mx-chain-testing-suite Target Branch: main

🚀 Environment Variables:

  • TIMESTAMP: 16052025-143458
  • PYTEST_EXIT_CODE: 0
    🎉 MultiversX CI/CD Workflow Complete!

@AdoAdoAdo AdoAdoAdo marked this pull request as ready for review May 19, 2025 11:22
@btc-fan
Copy link
Contributor

btc-fan commented May 19, 2025

Run Tests:
mx-chain-simulator-go: rc/andromeda
mx-chain-testing-suite: rc/andromeda

@github-actions
Copy link

⚠️ No report was generated due to an error or cancellation of the process.
Please checkout gh action logs for details

@github-actions
Copy link

📊 MultiversX Automated Test Report: View Report

🔄 Build Details:

  • mx-chain-go Commit Hash: a8f913e83b278deb77a43c414f6f3e0e52439c38
  • Current Branch: master
  • mx-chain-go Target Branch: ``
  • mx-chain-simulator-go Target Branch: ``
  • mx-chain-testing-suite Target Branch: ``

🚀 Environment Variables:

  • TIMESTAMP: 19052025-134528
  • PYTEST_EXIT_CODE: 0
    🎉 MultiversX CI/CD Workflow Complete!

@btc-fan
Copy link
Contributor

btc-fan commented May 19, 2025

Run Tests:
mx-chain-simulator-go: rc/andromeda
mx-chain-testing-suite: rc/andromeda

@github-actions
Copy link

⚠️ No report was generated due to an error or cancellation of the process.
Please checkout gh action logs for details

@btc-fan
Copy link
Contributor

btc-fan commented May 20, 2025

Run Tests:
mx-chain-simulator-go: last-andromeda
mx-chain-testing-suite: rc/andromeda

@github-actions
Copy link

⚠️ No report was generated due to an error or cancellation of the process.
Please checkout gh action logs for details

@github-actions
Copy link

📊 MultiversX Automated Test Report: View Report

🔄 Build Details:

  • mx-chain-go Commit Hash: 9f2444e9236026ad87bf8d77ec7e496e8e515c42
  • Current Branch: rc/andromeda
  • mx-chain-go Target Branch: master
  • mx-chain-simulator-go Target Branch: last-andromeda
  • mx-chain-testing-suite Target Branch: rc/andromeda

🚀 Environment Variables:

  • TIMESTAMP: 21052025-105858
  • PYTEST_EXIT_CODE: 0
    🎉 MultiversX CI/CD Workflow Complete!

@sstanculeanu sstanculeanu merged commit ebb1fd4 into master May 21, 2025
16 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

9 participants