cleanup consensus v2 subround end round #6540
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Base automatically changed from
refactor-v2-subround-signature
to
feat/equivalent-messages
October 17, 2024 08:42
AdoAdoAdo
changed the title
| sentSignatureTracker: sentSignatureTracker, | ||
| worker: worker, | ||
| signatureThrottler: signatureThrottler, | ||
| blockCommitted: false, |
There was a problem hiding this comment.
this is never set to true.. is it needed?
|
|
||
| messageSender := string(cnsDta.PubKey) | ||
|
|
||
| if sr.IsJobDone(sr.SelfPubKey(), sr.Current()) { |
There was a problem hiding this comment.
Suggested change
| if sr.IsJobDone(sr.SelfPubKey(), sr.Current()) { | |
| if sr.IsSelfJobDone(sr.Current()) { |
this one also covers multikey mode
| // TODO[cleanup cns finality]: remove the leader check | ||
| isEquivalentMessagesFlagEnabled := sr.EnableEpochsHandler().IsFlagEnabledInEpoch(common.EquivalentMessagesFlag, sr.GetHeader().GetEpoch()) | ||
| if !sr.IsSelfLeader() && !isEquivalentMessagesFlagEnabled { | ||
| if !sr.IsSelfLeader() { |
There was a problem hiding this comment.
I don't thinks this would be ok, as the invalid signers should be broadcast by the one who also sent the proof, not by the leader
| } | ||
| } | ||
|
|
||
| func (sposWorkerMock *SposWorkerMock) AddReceivedProofHandler(handler func(proofHandler consensus.ProofHandler)) { |
sstanculeanu
approved these changes
Dec 9, 2024
ssd04
approved these changes
Dec 9, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Reasoning behind the pull request
Proposed changes
Testing procedure
Pre-requisites
Based on the Contributing Guidelines the PR author and the reviewers must check the following requirements are met:
featbranch created?featbranch merging, do all satellite projects have a proper tag insidego.mod?