final proof is now sent on the common topic with META #6516
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
also small worker cleanup
AdoAdoAdo
reviewed
Oct 3, 2024
| return err | ||
| } | ||
|
|
||
| mcm.broadcast(common.EquivalentProofsTopic, msgProof, pkBytes) |
There was a problem hiding this comment.
is this a topic between metachain and all shards?
ssd04
reviewed
Oct 3, 2024
| // PrepareBroadcastFinalConsensusMessage prepares the validator final info data broadcast for when its turn comes | ||
| func (cm *commonMessenger) PrepareBroadcastFinalConsensusMessage(message *consensus.Message, consensusIndex int) { | ||
| err := cm.delayedBlockBroadcaster.SetFinalConsensusMessageForValidator(message, consensusIndex) | ||
| // PrepareBroadcastEquivalentProof prepares the validator final info data broadcast for when its turn comes |
| // BroadcastEquivalentProof will broadcast the proof for a header on the metachain common topic | ||
| func (mcm *metaChainMessenger) BroadcastEquivalentProof(proof *block.HeaderProof, pkBytes []byte) error { | ||
| if check.IfNilReflect(proof) { | ||
| return spos.ErrNilHeader |
| // BroadcastEquivalentProof will broadcast the proof for a header on the shard metachain common topic | ||
| func (scm *shardChainMessenger) BroadcastEquivalentProof(proof *block.HeaderProof, pkBytes []byte) error { | ||
| if check.IfNilReflect(proof) { | ||
| return spos.ErrNilHeader |
There was a problem hiding this comment.
maybe we can have a common inner function here for shard and meta and pass the topic
There was a problem hiding this comment.
applied the suggestion
AdoAdoAdo
approved these changes
Oct 3, 2024
ssd04
approved these changes
Oct 3, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Reasoning behind the pull request
Proposed changes
Testing procedure
Pre-requisites
Based on the Contributing Guidelines the PR author and the reviewers must check the following requirements are met:
featbranch created?featbranch merging, do all satellite projects have a proper tag insidego.mod?