Skip to content

Conversation

@ssd04
Copy link
Contributor

@ssd04 ssd04 commented Oct 3, 2024

Reasoning behind the pull request

  • Fixed part of the integrations tests
  • fix data race issues in consensus package

Testing procedure

  • To be tested with the feat branch

Pre-requisites

Based on the Contributing Guidelines the PR author and the reviewers must check the following requirements are met:

  • was the PR targeted to the correct branch?
  • if this is a larger feature that probably needs more than one PR, is there a feat branch created?
  • if this is a feat branch merging, do all satellite projects have a proper tag inside go.mod?

@ssd04 ssd04 self-assigned this Oct 3, 2024
@ssd04 ssd04 changed the title Fix integration tests Fix integration tests - part 1 Oct 3, 2024
@ssd04 ssd04 marked this pull request as ready for review October 3, 2024 11:12
AdoAdoAdo
AdoAdoAdo previously approved these changes Oct 3, 2024
Co-authored-by: Sorin Stanculeanu <[email protected]>
Co-authored-by: Sorin Stanculeanu <[email protected]>
@AdoAdoAdo AdoAdoAdo merged commit 5c24692 into feat/equivalent-messages Oct 4, 2024
5 checks passed
@AdoAdoAdo AdoAdoAdo deleted the fix-integration-tests branch October 4, 2024 09:29
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants