Update go 1.23 #6511

sstanculeanu · 2024-10-02T09:20:43Z

Reasoning behind the pull request

old version of libp2p libraries is used
go 1.20.7 is used

Proposed changes

update libp2p dependencies
update go to 1.22.4

Testing procedure

standard system test + half-half test + import db

Pre-requisites

Based on the Contributing Guidelines the PR author and the reviewers must check the following requirements are met:

was the PR targeted to the correct branch?
if this is a larger feature that probably needs more than one PR, is there a feat branch created?
if this is a feat branch merging, do all satellite projects have a proper tag inside go.mod?

…n-go into update_go_1.22 # Conflicts: # go.mod # go.sum

…n-go into update_go_1.22 # Conflicts: # cmd/node/config/enableEpochs.toml # common/constants.go # common/enablers/enableEpochsHandler.go # config/epochConfig.go

…n-go into update_go_1.22 # Conflicts: # cmd/node/config/enableEpochs.toml # common/constants.go # common/enablers/enableEpochsHandler.go # common/enablers/enableEpochsHandler_test.go # config/epochConfig.go # config/tomlConfig_test.go # go.mod # go.sum # node/metrics/metrics_test.go

…into update_go_1.22 # Conflicts: # common/constants.go # common/enablers/enableEpochsHandler_test.go # config/epochConfig.go # config/tomlConfig_test.go # docker/keygenerator/Dockerfile # docker/node/Dockerfile # docker/seednode/Dockerfile # docker/termui/Dockerfile # go.mod # go.sum # node/metrics/metrics.go # node/metrics/metrics_test.go # statusHandler/statusMetricsProvider.go # statusHandler/statusMetricsProvider_test.go

github-actions · 2025-02-18T17:59:57Z

⚠️ No report was generated due to an error or cancellation of the process.
Please checkout gh action logs for details

github-actions · 2025-02-19T08:11:25Z

📊 MultiversX Automated Test Report: View Report

🔄 Build Details:

mx-chain-go Commit Hash: 041dd8972611ffbc8aa1d97ab2c617807da4a5a4
Current Branch: update_go_1.22
mx-chain-go Target Branch: rc/barnard
mx-chain-simulator-go Target Branch: rc/barnard
mx-chain-testing-suite Target Branch: rc/barnard

🚀 Environment Variables:

TIMESTAMP: 19022025-081121
PYTEST_EXIT_CODE: 0
🎉 MultiversX CI/CD Workflow Complete!

sasurobert · 2025-02-20T08:02:49Z

cmd/node/config/enableEpochs.toml

    FixBackTransferOPCODEEnableEpoch = 2

+    # ValidationOnGobDecodeEnableEpoch represents the epoch when validation on GobDecode will be taken into account
+    ValidationOnGobDecodeEnableEpoch = 5


epoch = 2 ?

github-actions · 2025-02-20T14:21:31Z

📊 MultiversX Automated Test Report: View Report

🔄 Build Details:

mx-chain-go Commit Hash: 6cd58db027b1a90b28a3e197c91df7dde9261c65
Current Branch: update_go_1.22
mx-chain-go Target Branch: rc/barnard
mx-chain-simulator-go Target Branch: rc/barnard
mx-chain-testing-suite Target Branch: rc/barnard

🚀 Environment Variables:

TIMESTAMP: 20022025-142128
PYTEST_EXIT_CODE: 1
🎉 MultiversX CI/CD Workflow Complete!

andreibancioiu · 2025-02-20T15:17:33Z

testscommon/goroutines/filter.go

 	"github.com/libp2p/go-libp2p-nat.(*NAT)",
 	"net._C2func_getaddrinfo",
 	"net.cgoLookupIP", //  for net.cgoLookupIP and net.cgoLookupIPCNAME
+	"github.com/libp2p/go-libp2p/p2p/host/peerstore/pstoremem.(*memoryAddrBook)", // TODO remove it after pubsub update, fixed here https://github.com/libp2p/go-libp2p-pubsub/pull/568


How can we make sure we don't forget?

forgot, of course.. removed as it was released

andreibancioiu · 2025-02-20T15:18:15Z

dataRetriever/txpool/memorytests/memory_test.go

+	journals = append(journals, runScenario(t, newScenario(10, 10000, 100, "0"), memoryAssertion{36, 53}, memoryAssertion{16, 36}))
+	journals = append(journals, runScenario(t, newScenario(100000, 1, 1024, "0"), memoryAssertion{120, 140}, memoryAssertion{32, 60}))

 	// With larger memory footprint

-	journals = append(journals, runScenario(t, newScenario(100000, 3, 650, "0"), memoryAssertion{290, 335}, memoryAssertion{80, 148}))
-	journals = append(journals, runScenario(t, newScenario(150000, 2, 650, "0"), memoryAssertion{290, 335}, memoryAssertion{90, 160}))
-	journals = append(journals, runScenario(t, newScenario(300000, 1, 650, "0"), memoryAssertion{290, 335}, memoryAssertion{100, 190}))
-	journals = append(journals, runScenario(t, newScenario(30, 10000, 650, "0"), memoryAssertion{290, 335}, memoryAssertion{60, 132}))
-	journals = append(journals, runScenario(t, newScenario(300, 1000, 650, "0"), memoryAssertion{290, 335}, memoryAssertion{60, 148}))
+	journals = append(journals, runScenario(t, newScenario(100000, 3, 650, "0"), memoryAssertion{290, 340}, memoryAssertion{80, 148}))
+	journals = append(journals, runScenario(t, newScenario(150000, 2, 650, "0"), memoryAssertion{290, 340}, memoryAssertion{90, 160}))
+	journals = append(journals, runScenario(t, newScenario(300000, 1, 650, "0"), memoryAssertion{290, 340}, memoryAssertion{100, 190}))
+	journals = append(journals, runScenario(t, newScenario(30, 10000, 650, "0"), memoryAssertion{290, 340}, memoryAssertion{60, 132}))
+	journals = append(journals, runScenario(t, newScenario(300, 1000, 650, "0"), memoryAssertion{290, 340}, memoryAssertion{60, 148}))


Due to relayed v3, I think, right?

github-actions · 2025-02-20T15:23:35Z

📊 MultiversX Automated Test Report: View Report

🔄 Build Details:

mx-chain-go Commit Hash: 2fdffff6c2c70b020db9fafe3358cd1445a9f006
Current Branch: update_go_1.22
mx-chain-go Target Branch: rc/barnard
mx-chain-simulator-go Target Branch: rc/barnard
mx-chain-testing-suite Target Branch: rc/barnard

🚀 Environment Variables:

TIMESTAMP: 20022025-152333
PYTEST_EXIT_CODE: 0
🎉 MultiversX CI/CD Workflow Complete!

github-actions · 2025-02-28T12:50:42Z

📊 MultiversX Automated Test Report: View Report

🔄 Build Details:

mx-chain-go Commit Hash: 5b2d632b9a0cce448b1620c6be39bc1528c67270
Current Branch: update_go_1.22
mx-chain-go Target Branch: rc/barnard
mx-chain-simulator-go Target Branch: rc/barnard
mx-chain-testing-suite Target Branch: rc/barnard

🚀 Environment Variables:

TIMESTAMP: 28022025-125040
PYTEST_EXIT_CODE: 0
🎉 MultiversX CI/CD Workflow Complete!

danidrasovean

Half - Half test: update_go_1.22-2fdffff6c2 and rc/barnard

--- Specific errors ---

block hash does not match 0
wrong nonce in block 12
miniblocks does not match 0
num miniblocks does not match 0
miniblock hash does not match 0
block bodies does not match 0
receipts hash missmatch 0

/------/

--- Statistics ---

Nr. of all ERRORS: 10
Nr. of all WARNS: 206
Nr. of new ERRORS: 10
Nr. of new WARNS: 17
Nr. of PANICS: 0
Nodes with panic: []

/------/

sstanculeanu added 11 commits July 17, 2024 19:13

Update go to 1.22

af85cff

Merge branch 'rc/v1.7.next1' of https://github.com/multiversx/mx-chai…

c21d818

…n-go into update_go_1.22 # Conflicts: # go.mod # go.sum

reverted code for tests

90fb9ce

updated mx-chain-communication-go

52baf32

fix invalid signers test

9076c59

Merge branch 'rc/v1.7.next1' of https://github.com/multiversx/mx-chai…

931ad9a

…n-go into update_go_1.22 # Conflicts: # cmd/node/config/enableEpochs.toml # common/constants.go # common/enablers/enableEpochsHandler.go # config/epochConfig.go

updated deps

85e8f9e

updated deps

5970dfa

updated deps

afa76af

updated linter

200d585

sstanculeanu self-assigned this Oct 2, 2024

sstanculeanu added area:libp2p area:processing impact:medium interested:protocol type:improvement labels Feb 18, 2025

sstanculeanu added 2 commits February 18, 2025 18:52

updated go to 1.23.6

8593768

sstanculeanu marked this pull request as ready for review February 18, 2025 17:58

updated chain simulator pipeline as well

041dd89

sstanculeanu changed the title ~~Update go 1.22~~ Update go 1.23 Feb 19, 2025

sasurobert reviewed Feb 20, 2025

View reviewed changes

sstanculeanu added 2 commits February 20, 2025 15:51

fixes after review + updated deps

6568813

go mod tidy

6cd58db

updated mx-chain-go

2fdffff

sasurobert previously approved these changes Feb 20, 2025

View reviewed changes

andreibancioiu previously approved these changes Feb 20, 2025

View reviewed changes

removed filter on remaining goroutines

5b2d632

sstanculeanu dismissed stale reviews from andreibancioiu and sasurobert via 5b2d632 February 28, 2025 12:21

andreibancioiu approved these changes Feb 28, 2025

View reviewed changes

sasurobert approved these changes Feb 28, 2025

View reviewed changes

danidrasovean approved these changes Feb 28, 2025

View reviewed changes

sstanculeanu merged commit 579a5a9 into rc/barnard Feb 28, 2025
8 checks passed

sstanculeanu deleted the update_go_1.22 branch February 28, 2025 15:16

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Uh oh!

Update go 1.23 #6511

Update go 1.23 #6511

Uh oh!

sstanculeanu commented Oct 2, 2024 •

edited

Loading

Uh oh!

github-actions bot commented Feb 18, 2025

Uh oh!

github-actions bot commented Feb 19, 2025

Uh oh!

sasurobert Feb 20, 2025

Uh oh!

github-actions bot commented Feb 20, 2025

Uh oh!

andreibancioiu Feb 20, 2025

Uh oh!

sstanculeanu Feb 28, 2025

Uh oh!

andreibancioiu Feb 20, 2025

Uh oh!

github-actions bot commented Feb 20, 2025

Uh oh!

github-actions bot commented Feb 28, 2025

Uh oh!

danidrasovean left a comment

Uh oh!

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

5 participants

Update go 1.23 #6511

Update go 1.23 #6511

Uh oh!

Conversation

sstanculeanu commented Oct 2, 2024 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Reasoning behind the pull request

Proposed changes

Testing procedure

Pre-requisites

Uh oh!

github-actions bot commented Feb 18, 2025

Uh oh!

github-actions bot commented Feb 19, 2025

Uh oh!

sasurobert Feb 20, 2025

Choose a reason for hiding this comment

Uh oh!

github-actions bot commented Feb 20, 2025

Uh oh!

andreibancioiu Feb 20, 2025

Choose a reason for hiding this comment

Uh oh!

sstanculeanu Feb 28, 2025

Choose a reason for hiding this comment

Uh oh!

andreibancioiu Feb 20, 2025

Choose a reason for hiding this comment

Uh oh!

github-actions bot commented Feb 20, 2025

Uh oh!

github-actions bot commented Feb 28, 2025

Uh oh!

danidrasovean left a comment

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

5 participants

sstanculeanu commented Oct 2, 2024 •

edited

Loading