Skip to content

Conversation

@sasurobert
Copy link
Contributor

Reasoning behind the pull request

Proposed changes

Testing procedure

Pre-requisites

Based on the Contributing Guidelines the PR author and the reviewers must check the following requirements are met:

  • was the PR targeted to the correct branch?
  • if this is a larger feature that probably needs more than one PR, is there a feat branch created?
  • if this is a feat branch merging, do all satellite projects have a proper tag inside go.mod?

@sasurobert sasurobert changed the base branch from rc/v1.7.next1 to feat/economics-gas-improve-v2 June 20, 2024 09:00
@sasurobert sasurobert changed the title Change penalise gas - To be redirected for 1.8 Change penalise gas Jun 20, 2024
@raduchis raduchis self-requested a review June 20, 2024 10:56
raduchis
raduchis previously approved these changes Jun 20, 2024
@sasurobert sasurobert changed the base branch from feat/economics-gas-improve-v2 to rc/barnard November 4, 2024 12:37
andreibancioiu
andreibancioiu previously approved these changes Nov 5, 2024
raduchis
raduchis previously approved these changes Nov 5, 2024
@sasurobert sasurobert dismissed stale reviews from raduchis and andreibancioiu via 93a8198 November 11, 2024 08:31
@github-actions
Copy link

📊 MultiversX Automated Test Report: View Report

🔄 Build Details:

  • mx-chain-go Commit Hash: 93a819853081a2c13c1995cad3bc4dbae3fb143f
  • Current Branch: change-penaliseGas
  • mx-chain-go Target Branch: rc/barnard
  • mx-chain-simulator-go Target Branch: rc/barnard
  • mx-chain-testing-suite Target Branch: rc/barnard

🚀 Environment Variables:

  • TIMESTAMP: 11112024-084413
  • PYTEST_EXIT_CODE: 0
    🎉 MultiversX CI/CD Workflow Complete!

@github-actions
Copy link

📊 MultiversX Automated Test Report: View Report

🔄 Build Details:

  • mx-chain-go Commit Hash: 0b6485b716c3366e4f46f43a829399f671d50a76
  • Current Branch: change-penaliseGas
  • mx-chain-go Target Branch: rc/barnard
  • mx-chain-simulator-go Target Branch: rc/barnard
  • mx-chain-testing-suite Target Branch: rc/barnard

🚀 Environment Variables:

  • TIMESTAMP: 11112024-101355
  • PYTEST_EXIT_CODE: 0
    🎉 MultiversX CI/CD Workflow Complete!

Copy link
Contributor

@gabi-vuls gabi-vuls left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Normal allin test: 1.7.13-patch2-41962f78a1 -> change-penaliseGas-0b6485b716

--- Specific errors ---

block hash does not match 1868
wrong nonce in block 795
miniblocks does not match 0
num miniblocks does not match 0
miniblock hash does not match 0
block bodies does not match 0
receipts hash missmatch 0

/------/

--- Statistics ---

Nr. of all ERRORS: 0
Nr. of all WARNS: 437
Nr. of new ERRORS: 0
Nr. of new WARNS: 7
Nr. of PANICS: 0
Nodes with panic: []

/------/

--- System test go ---

All scenarios from system-test-go are OK!
/------/

@sasurobert sasurobert merged commit f293c96 into rc/barnard Nov 14, 2024
8 checks passed
@sasurobert sasurobert deleted the change-penaliseGas branch November 14, 2024 08:18
@bariswinner
Copy link

T

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

6 participants