MX-15029: Accept multiple delegateVoting #5857
Conversation
Codecov ReportAttention:
Additional details and impacted files@@ Coverage Diff @@
## feat/governance-fixes #5857 +/- ##
======================================================
Coverage 80.32% 80.32%
======================================================
Files 709 709
Lines 93973 94010 +37
======================================================
+ Hits 75480 75515 +35
Misses 13215 13215
- Partials 5278 5280 +2 ☔ View full report in Codecov by Sentry. |
| if err != nil { | ||
| return nil, err | ||
| } | ||
| return onGoingListV2, nil |
There was a problem hiding this comment.
You should return onGoingList not the v2
There was a problem hiding this comment.
this method will be called only after GovernanceFixes gets activated, that means there is no ongoing v1 proposal, thus the information is not necessary anymore.
| if err != nil { | ||
| return nil, err | ||
| } | ||
| return onGoingListV2, nil |
| require.False(t, handler.IsFlagEnabled(common.ESDTFlagInSpecificEpochOnly)) // == | ||
| require.True(t, handler.IsFlagEnabled(common.GovernanceFlag)) | ||
| require.False(t, handler.IsFlagEnabled(common.GovernanceFlagInSpecificEpochOnly)) // == | ||
| require.True(t, handler.IsFlagEnabled(common.GovernanceDisableProposeFlag)) // == |
There was a problem hiding this comment.
what is the purpose for the == comments?
There was a problem hiding this comment.
Will remove in the next PR.
| } | ||
|
|
||
| message DelegatedWithAddress { | ||
| uint64 Nonce = 1; |
There was a problem hiding this comment.
any reason we don't add a json tag for nonce, or why we do for the others?
There was a problem hiding this comment.
Will add in the next PR.
Reasoning behind the pull request
Proposed changes
Testing procedure