Linter fixes for rc/v1.6.0 - 2023.08.30

[iulianpascalau]

Reasoning behind the pull request

• linter issues

Proposed changes

Implemented the following recommendations:

ioutil.ReadFile:  Deprecated: As of Go 1.16, this function simply calls os.ReadFile
ioutil.ReadAll:   Deprecated: As of Go 1.16, this function simply calls io.ReadAll
ioutil.TempDir:   Deprecated: As of Go 1.17, this function simply calls os.MkdirTemp
ioutil.WriteFile: Deprecated: As of Go 1.16, this function simply calls os.WriteFile
//+build comments can be removed

Testing procedure

• standard system test + termui check to see the memory consumed by the process is not 0

Pre-requisites

Based on the Contributing Guidelines the PR author and the reviewers must check the following requirements are met:

• was the PR targeted to the correct branch?
• if this is a larger feature that probably needs more than one PR, is there a feat branch created?
• if this is a feat branch merging, do all satellite projects have a proper tag inside go.mod?

[codecov]

Codecov Report

Patch coverage: 93.41% and project coverage change: +0.02% 🎉

Comparison is base (bd55ade) 80.06% compared to head (e2c9749) 80.08%.
Report is 64 commits behind head on rc/v1.6.0.

❗ Current head e2c9749 differs from pull request most recent head 49bf503. Consider uploading reports for the commit 49bf503 to get more accurate results

Additional details and impacted files

@@              Coverage Diff              @@
##           rc/v1.6.0    #5546      +/-   ##
=============================================
+ Coverage      80.06%   80.08%   +0.02%     
=============================================
  Files            708      706       -2     
  Lines          93712    93674      -38     
=============================================
- Hits           75030    75022       -8     
+ Misses         13338    13319      -19     
+ Partials        5344     5333      -11     

Files Changed	Coverage Δ
api/middleware/responseLogger.go	66.66% <0.00%> (ø)
genesis/process/genesisBlockCreator.go	65.60% <0.00%> (-0.36%)	⬇️
outport/process/factory/check.go	80.00% <0.00%> (-5.72%)	⬇️
process/block/preprocess/basePreProcess.go	79.57% <0.00%> (-0.35%)	⬇️
process/block/preprocess/transactions.go	60.62% <57.14%> (-0.03%)	⬇️
process/coordinator/process.go	75.82% <71.42%> (-0.03%)	⬇️
outport/process/outportDataProvider.go	62.45% <87.34%> (+8.82%)	⬆️
...etachain/intermediateProcessorsContainerFactory.go	86.11% <90.47%> (-2.13%)	⬇️
...ry/shard/intermediateProcessorsContainerFactory.go	84.26% <90.47%> (-1.62%)	⬇️
factory/processing/processComponents.go	80.89% <96.22%> (-0.09%)	⬇️
... and 21 more

... and 3 files with indirect coverage changes

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

[gabi-vuls]

Normal allin test: v1.5.13-dev-config-8c685c8e00 -> linter-fixes-2023.08.30-14de684909

--- Specific errors ---

block hash does not match 2917
wrong nonce in block 1272
miniblocks does not match 0
num miniblocks does not match 0
miniblock hash does not match 0
block bodies does not match 0
receipts hash missmatch 0

/------/

--- Statistics ---

Nr. of all ERRORS: 0
Nr. of all WARNS: 153
Nr. of new ERRORS: 0
Nr. of new WARNS: 2
Nr. of PANICS: 0

/------/