Extended the search for the full history resolver #5544
Conversation
… is wrongly provided
| val, err := resolver.getFromStorage(testKey, testEpoch) | ||
| assert.Nil(t, err) | ||
| assert.Equal(t, testValue, val) | ||
| }) |
There was a problem hiding this comment.
Formatting / newline needed (and below).
There was a problem hiding this comment.
I generally prefer inner tests not separated by a new line. We should agree in a future clean code meeting if we will add empty lines or not in this particular case as to slowly align all existing code
| assert.Nil(t, err) | ||
| assert.Equal(t, 0, len(val)) | ||
| }) | ||
| t.Run("get from epoch returned error and will default to search first", func(t *testing.T) { |
There was a problem hiding this comment.
"will fallback to search first".
Codecov ReportPatch coverage:
Additional details and impacted files@@ Coverage Diff @@
## rc/v1.6.0 #5544 +/- ##
=============================================
- Coverage 80.10% 80.10% -0.01%
=============================================
Files 708 708
Lines 93709 93712 +3
=============================================
+ Hits 75063 75064 +1
- Misses 13300 13303 +3
+ Partials 5346 5345 -1
☔ View full report in Codecov by Sentry. |
iulianpascalau
dismissed stale reviews from andreibancioiu and sstanculeanu
via
0739bad
gabi-vuls
left a comment
gabi-vuls
left a comment
There was a problem hiding this comment.
Normal allin test: v1.5.13-dev-config-8c685c8e00 -> extend-full-history-resolv-0739badb6e
--- Specific errors ---
block hash does not match 7756
wrong nonce in block 2769
miniblocks does not match 0
num miniblocks does not match 0
miniblock hash does not match 0
block bodies does not match 0
receipts hash missmatch 0
/------/
--- Statistics ---
Nr. of all ERRORS: 0
Nr. of all WARNS: 247
Nr. of new ERRORS: 0
Nr. of new WARNS: 2
Nr. of PANICS: 0
/------/
Reasoning behind the pull request
Proposed changes
Testing procedure
rc/v1.6.0branch and the random observer node will not be able to finish the bootstrapping phase, it will always error with an error like:after about 1 minute after it was started.
Pre-requisites
Based on the Contributing Guidelines the PR author and the reviewers must check the following requirements are met:
featbranch created?featbranch merging, do all satellite projects have a proper tag insidego.mod?