Skip to content

Conversation

@ssd04
Copy link
Contributor

@ssd04 ssd04 commented Aug 30, 2023

Reasoning behind the pull request

  • Enabled sharded storage feature on UserAccounts and PeerAccounts storers

Proposed changes

  • Set ShardIDProviderType and NumShards in config

Testing procedure

  • Standard testing procedure

Pre-requisites

Based on the Contributing Guidelines the PR author and the reviewers must check the following requirements are met:

  • was the PR targeted to the correct branch?
  • if this is a larger feature that probably needs more than one PR, is there a feat branch created?
  • if this is a feat branch merging, do all satellite projects have a proper tag inside go.mod?

@ssd04 ssd04 self-assigned this Aug 30, 2023
@iulianpascalau iulianpascalau self-requested a review August 30, 2023 08:36
@codecov
Copy link

codecov bot commented Aug 30, 2023

Codecov Report

Patch coverage: 93.15% and project coverage change: +0.01% 🎉

Comparison is base (b0a39d7) 80.03% compared to head (399eda9) 80.05%.
Report is 64 commits behind head on rc/v1.6.0.

❗ Current head 399eda9 differs from pull request most recent head 38f5d6d. Consider uploading reports for the commit 38f5d6d to get more accurate results

Additional details and impacted files
@@              Coverage Diff              @@
##           rc/v1.6.0    #5543      +/-   ##
=============================================
+ Coverage      80.03%   80.05%   +0.01%     
=============================================
  Files            708      708              
  Lines          93696    93709      +13     
=============================================
+ Hits           74994    75021      +27     
+ Misses         13351    13343       -8     
+ Partials        5351     5345       -6     
Files Changed Coverage Δ
...ocess/transactionEvaluator/transactionSimulator.go 80.76% <0.00%> (ø)
outport/process/alteredaccounts/tokensProcessor.go 91.01% <87.87%> (+11.24%) ⬆️
common/enablers/enableEpochsHandler.go 100.00% <100.00%> (ø)
common/enablers/epochFlags.go 98.71% <100.00%> (+0.01%) ⬆️
facade/nodeFacade.go 93.87% <100.00%> (+0.01%) ⬆️
genesis/process/shardGenesisBlockCreator.go 76.91% <100.00%> (+0.03%) ⬆️
node/external/logs/logsConverter.go 100.00% <100.00%> (ø)
node/metrics/metrics.go 100.00% <100.00%> (ø)
...process/alteredaccounts/alteredAccountsProvider.go 88.23% <100.00%> (ø)
process/smartContract/process.go 64.90% <100.00%> (ø)
... and 3 more

... and 2 files with indirect coverage changes

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Copy link
Contributor

@gabi-vuls gabi-vuls left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Normal allin test: v1.5.13-dev-config-8c685c8e00 -> enable-sharded-storage-38f5d6d78d

--- Specific errors ---

block hash does not match 2099
wrong nonce in block 900
miniblocks does not match 0
num miniblocks does not match 0
miniblock hash does not match 0
block bodies does not match 0
receipts hash missmatch 0

/------/

--- Statistics ---

Nr. of all ERRORS: 0
Nr. of all WARNS: 173
Nr. of new ERRORS: 0
Nr. of new WARNS: 1
Nr. of PANICS: 0

/------/

@ssd04 ssd04 merged commit bc426e1 into rc/v1.6.0 Aug 30, 2023
@ssd04 ssd04 deleted the enable-sharded-storage branch August 30, 2023 14:17
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

6 participants