EN-13432: Nodes shuffler refactoring #4799
Conversation
Codecov Report
Additional details and impacted files@@ Coverage Diff @@
## feat/consensus-size-changes #4799 +/- ##
==============================================================
Coverage ? 70.82%
==============================================================
Files ? 645
Lines ? 85016
Branches ? 0
==============================================================
Hits ? 60214
Misses ? 20288
Partials ? 4514 Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here. ☔ View full report at Codecov. |
bogdan-rosianu
changed the title
| shardHysteresis uint32 | ||
| metaHysteresis uint32 | ||
| currentChainParameters config.ChainParametersByEpochConfig | ||
| //shardHysteresis uint32 |
There was a problem hiding this comment.
remove commented out code
| ShuffleBetweenShards bool | ||
| MaxNodesEnableConfig []config.MaxNodesChangeConfig | ||
| EnableEpochsHandler common.EnableEpochsHandler | ||
| ChainParametersHandler ChainParametersHandler |
There was a problem hiding this comment.
check also if the notify order for chain parameters handler.
it needs to at least be before nodes coordinator.
There was a problem hiding this comment.
refactored - so that it uses the epoch notifier with ordering
|
|
||
| paramsHolder := &chainParametersHolder{ | ||
| currentChainParameters: currentParams, | ||
| currentChainParameters: earliestChainParams, // will be updated on the epoch notifier handlers |
There was a problem hiding this comment.
yup, that is the behavior right now. I do not see a good reason why we should change this in the future.
Reasoning behind the pull request
Proposed changes
chainParametersHandlerinto itTesting procedure
Pre-requisites
Based on the Contributing Guidelines the PR author and the reviewers must check the following requirements are met:
featbranch created?featbranch merging, do all satellite projects have a proper tag insidego.mod?