Skip to content

*: Bump version to v0.15.0 and add changelog entries#58

Merged
mxinden merged 1 commit into
multiformats:masterfrom
mxinden:bump-version
May 10, 2022
Merged

*: Bump version to v0.15.0 and add changelog entries#58
mxinden merged 1 commit into
multiformats:masterfrom
mxinden:bump-version

Conversation

@mxinden

@mxinden mxinden commented May 6, 2022

Copy link
Copy Markdown
Member

Follow up to #53 and #56.

@mxinden mxinden requested review from dignifiedquire and vmx May 6, 2022 10:54

@dignifiedquire dignifiedquire left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm, but it is not actually a breaking change, is it?

@mxinden

mxinden commented May 6, 2022

Copy link
Copy Markdown
Member Author

lgtm, but it is not actually a breaking change, is it?

In case a user exhaustively matches on Protocol, compilation will fail due to the new variant Protocol::Noise.

@dignifiedquire

Copy link
Copy Markdown
Member

then maybe add non_exhaustive to the enzm for easier additions in the future?

@mxinden

mxinden commented May 6, 2022

Copy link
Copy Markdown
Member Author

then maybe add non_exhaustive to the enzm for easier additions in the future?

I would argue that as a downstream user I would appreciate the breaking change in Protocol, i.e. I would appreciate to be notified of the change (additional variant) by the compiler. There are some downstream users who would want to make use of the new protocol, e.g. a Prometheus exporter which is tracking the observed protocols as a metric.

@mxinden mxinden merged commit 8a4bd49 into multiformats:master May 10, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants