Add SoftWare Heritage persistent IDentifier snapshots #207
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
vmx
approved these changes
Feb 17, 2021
Member
vmx
left a comment
vmx
left a comment
There was a problem hiding this comment.
Before merging I'd like to get an approval/thumbs up from other maintainers as well.
See https://docs.softwareheritage.org/devel/swh-model/persistent-identifiers.html for the technical details of that spec. Software Heritage has done a superb job promoting content addressing in general, and their identifier scheme (SWHIDs, for short) in particular. By supporting them in CIDs / IPLD, I hope the IPFS ecosystem can align itself with that effort. Per the linked documentation, SWHIDs have their own nested grammar and versioning scheme. I begun by taking the version 1 core identifier grammar, unrolled it, and replaced `:` with `-` per the guidelines on separators, with the result being these 5 rows. There is overlap between the remaining for and git-raw, so this just adds SWHID snapshots for now.
warpfork
approved these changes
Aug 21, 2021
Contributor
warpfork
left a comment
warpfork
left a comment
There was a problem hiding this comment.
I'm good with this. 👍
I think no one has raised any objections to this code, in particular, at all -- so I'll merge this shortly if no objections appear.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
See
https://docs.softwareheritage.org/devel/swh-model/persistent-identifiers.html
for the technical details of that spec.
Software Heritage has done a superb job promoting content addressing in
general, and their identifier scheme (SWHIDs, for short) in particular.
By supporting them in CIDs / IPLD, I hope the IPFS ecosystem can align
itself with that effort.
Per the linked documentation, SWHIDs have their own nested grammar and
versioning scheme. I begun by taking the version 1 core identifier
grammar, unrolled it, and replaced
:with-per the guidelines onseparators, with the result being these 5 rows.
There is overlap between the remaining for and git-raw, so this just
adds SWHID snapshots for now.