Making asCID enumerable brakes assert functions in tests

[Gozala]

After updating to v10 lot of our tests started fail, as it turns out problem is introduced by a asCID property becoming enumerable. Most assert functions seem to get tripped on link.asCID field either crashing with stack overflow or simply deciding cids aren't equal 😭

I'm not sure what the fix is here, but it's kind of a pain to deal with now.

[achingbrain]

See also #208 - when decoding CIDs from the return value of Uint8Array.subarray, it can cause byteOffset to be different between two CID instances that otherwise have the same version, code and multihash so deep equality tests fail where they previously passed.

[Gozala]

Turns out that chai deepEqual assert handles asCID fine because it does proper memoization during assertions, we have not run into #208 because we don't really use CIDv0 anywhere and that only can occur with v0 CIDs as per #216 & either way that can be resolved by that PR.

Our problems seem to be coming from https://www.npmjs.com/package/chai-subset package which does not do any memoization and consequently it fails with stack overflow. And we have to to use chai-subset because chai deepNestedInclude has a strange behavior with arrays.

I think our our options are to either:

1. Fix chai-subset and leave asCID as is, because if all other properties are deepEqual values should be considered deep equal.
2. Switch to alternative signalling described in Trim Link / CID interface and introduce something like LinkView interface #214 which boils down to using cid['/'] === cid.bytes instead of cid.asCID === this, which would work equally well, but hopefully will cause far less problems with third party code that does not handle self-referential data (although if I recall correctly @mikeal intentionally wanted to break code that naively attempted to treat CID as something else, but maybe his position shifted given more data)

[github-actions]

🎉 This issue has been resolved in version 10.0.2 🎉

The release is available on:

• npm package (@latest dist-tag)
• GitHub release

Your semantic-release bot 📦🚀