feat!: remove .byteLength and .byteOffset properties from CID#210
Closed
achingbrain wants to merge 1 commit intomasterfrom
Closed
feat!: remove .byteLength and .byteOffset properties from CID#210achingbrain wants to merge 1 commit intomasterfrom
achingbrain wants to merge 1 commit intomasterfrom
Conversation
From #203 > I would like to also address byteOffset, byteLength fields. I don't think they were a bad idea, it's just I was not allowed to complete implementation of that idea. Given that the feature is incomplete and untested, remove it for now and if it's required it can be implemented fully in the future. Fixes #208 BREAKING CHANGE: The CID class no longer has `.byteOffset` and `.byteLength` properties - these can be accessed via the `.bytes` property instead
Member
Author
|
#211 could be merged instead of this. |
Member
Author
|
Closing in favour of #215 as it's less disruptive |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
From #203
Given that the feature is incomplete, untested and causes assertions elsewhere to fail, remove it for now and if it's required it can be implemented fully in the future.
Fixes #208
BREAKING CHANGE: The CID class no longer has
.byteOffsetand.byteLengthproperties - these can be accessed via the.bytesproperty instead