Performance of Object.defineProperties use in the CID class

[achingbrain]

I'm doing some profiling to debug high CPU usage and Object.defineProperties takes up rather a lot of execution time:

There's an interesting post here where someone tries to optimise very similar usage, an interesting quote being:

there [is] basically no truly efficient way to make properties nonenumerable

Would it be so terrible to remove the Object.definedProperties invocation here?

If we absolutely must have some sort of no-you-cannot-access-them-don't-even-think-about-it-the-sky-will-fall-on-our-heads-type protection for these fields could we switch to using private class fields instead?

[RangerMauve]

That's a good idea. It could be paired with adding getters for the readonly properties.

[rvagg]

I'm not so tied to them needing to be read-only or hidden. Private class fields are only going to help in 3 of the cases, but even there we still kind of want access to them externally—cid.asCID has been useful elsewhere for instance; although not strictly necessary. "hidden" only means non-enumerable, they're still accessible.

getters are another possibility we could consider. Could you rerun your profiling with those fields as getters instead and see if it makes a difference?

/cc @Gozala who will probably have opinions too—although I suspect that his typescript perspective might make him lean toward saying the annotations are good enough protection?

[Gozala]

/cc @Gozala who will probably have opinions too—although I suspect that his typescript perspective might make him lean toward saying the annotations are good enough protection?

I do indeed have no opinion in regards to this & would not mind removing whole Object.defineProperties block.

[github-actions]

🎉 This issue has been resolved in version 10.0.0 🎉

The release is available on:

• npm package (@latest dist-tag)
• GitHub release

Your semantic-release bot 📦🚀