Skip to content

[pickers] Fix theme augmentation issues #7800

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
LukasTy merged 6 commits into from
Feb 2, 2023
Merged

[pickers] Fix theme augmentation issues #7800

LukasTy merged 6 commits into from
Feb 2, 2023

Conversation

@LukasTy
Copy link
Member

@LukasTy LukasTy commented Feb 2, 2023

Fix #7779

  • Fix missing class exports
  • Add missing range field components
  • Fix incorrect imports/references
  • Improve test/spec coverage

@LukasTy LukasTy added type: bug It doesn't behave as expected. typescript scope: pickers Changes related to the date/time pickers. labels Feb 2, 2023
@LukasTy LukasTy self-assigned this Feb 2, 2023
@mui-bot
Copy link

mui-bot commented Feb 2, 2023 •
edited
Loading

Messages
📖 Netlify deploy preview: https://deploy-preview-7800--material-ui-x.netlify.app/

These are the results for the performance tests:

Test case Unit Min Max Median Mean σ
Filter 100k rows ms 715.8 1,098.6 715.8 906.66 159.604
Sort 100k rows ms 660.5 1,196 1,196 960.58 201.746
Select 100k rows ms 214.2 396 305 299.88 58.603
Deselect 100k rows ms 140.9 328.1 265.6 238.86 68.075

Generated by 🚫 dangerJS against 698fc5d

@github-actions github-actions bot added the PR: out-of-date The pull request has merge conflicts and can't be merged. label Feb 2, 2023
@github-actions
Copy link

github-actions bot commented Feb 2, 2023

This pull request has conflicts, please resolve those before we can evaluate the pull request.

flaviendelangle
flaviendelangle approved these changes Feb 2, 2023
View reviewed changes
Copy link
Member

@flaviendelangle flaviendelangle left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the cleaning !

@github-actions github-actions bot removed the PR: out-of-date The pull request has merge conflicts and can't be merged. label Feb 2, 2023
@LukasTy LukasTy enabled auto-merge (squash) February 2, 2023 14:10
@LukasTy LukasTy merged commit efa0fbe into mui:next Feb 2, 2023
@LukasTy LukasTy deleted the fix-theme-augmentation branch February 2, 2023 14:23
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@flaviendelangle flaviendelangle flaviendelangle approved these changes

@alexfauquette alexfauquette Awaiting requested review from alexfauquette

Assignees

@LukasTy LukasTy

Labels

scope: pickers Changes related to the date/time pickers. type: bug It doesn't behave as expected. typescript

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

[pickers] TypeScript compilation errors in @mui/[email protected] themeAugmentation

3 participants

@LukasTy @mui-bot @flaviendelangle