[data grid] Fix column dimensions import/export with flex and resizing

[flaviendelangle]

Fixes #4310

This PR fixes two small bugs raised in #4310

• When a user resizes a column, we set flex: undefined on this column. This is to make sure that the column is not automatically resized when we re-run the sizing process of all columns (when a new column is created for instance). But when saving the state, this flex: undefined is not stored in the JSON, so when restoring, the columns has flex again.

Solution: Set flex: 0 instead of flex: undefined

• The default maxWidth property equals Infinity. But JSON.stringify(Infinity) === 'null'. So when restoring it, we have maxWidth: null, which is handled like maxWidth: 0.

It was raised by @m4theushw in #3816 (comment), I thought maxWidth: null would work but I was clearly wrong.

Solution: Set maxWidth: 'Infinity' in the export and parse in correctly on restore.

[mui-bot]

These are the results for the performance tests:

Test case	Unit	Min	Max	Median	Mean	σ
Filter 100k rows	ms	235.7	461.4	334.2	339.36	92.491
Sort 100k rows	ms	426.4	919.2	782.1	731.36	163.587
Select 100k rows	ms	90.9	222.6	207	165.2	48.195
Deselect 100k rows	ms	91.8	213.7	213.7	146.96	50.708

Generated by 🚫 dangerJS against 623644c

[m4theushw]

Wouldn't be easier to not export values with Infinity or null? We can use the default values when restoring.

[m4theushw]

This change doesn't seem necessary to fix #4310 but makes sense to set 0.

[flaviendelangle]

When I did not do this one, I had the flex coming back on re-import.
Maybe it only occurs in some scenario.

As 0 make sense, I propose to keep it.

[flaviendelangle]

@m4theushw

Wouldn't be easier to not export values with Infinity or null? We can use the default values when restoring.

It was my 1st idea
But it does not support one edge case:

• Create a custom column type with a maxWidth: 200
• Create a column with this column type and maxWidth: Infinity
• Export the column
• Re-import the column => you have maxWidth: 200 instead of maxWidth: Infinity

[m4theushw]

But it does not support one edge case:

We could export Infinity as -1 instead. This would avoid to have to update GridColumnDimensions.

[flaviendelangle]

We could export Infinity as -1 instead

When a column definition have maxWidth: -1, would you set maxWidth: Infinity before storing it in the state
Or would you change the of the functions using maxWidth (useGridColumnResize for instance).

[m4theushw]

Or would you change the of the functions using maxWidth (useGridColumnResize for instance).

I didn't understand this part. But I would always convert -1 to Infinity. Currently, we don't check if the value is negative.

[flaviendelangle]

I didn't understand this part. But I would always convert -1 to Infinity. Currently, we don't check if the value is negative.

If we did not convert -1 => Infinity in the state, then we would have to make the check were the property is used to say "if -1 then do not clamp"

[m4theushw]

It's simpler to convert all dimensions that have -1 to Infinity than to check their values to not clamp. So for the question below my answer is yes.

When a column definition have maxWidth: -1, would you set maxWidth: Infinity before storing it in the state

[flaviendelangle]

Done