[code-infra] Reuse useReactVersion script from the monorepo
#13710
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Deploy preview: https://deploy-preview-13710--material-ui-x.netlify.app/ |
|
This pull request has conflicts, please resolve those before we can evaluate the pull request. |
github-actions
bot
added
the
PR: out-of-date
github-actions
bot
removed
the
PR: out-of-date
cherniavskii
changed the title
useReactVersion script from the monorepouseReactVersion script from the monorepo
|
This pull request has conflicts, please resolve those before we can evaluate the pull request. |
github-actions
bot
added
the
PR: out-of-date
cherniavskii
commented
Jul 22, 2024
| "@mui/internal-test-utils": "^1.0.4", | ||
| "@mui/material": "^5.16.2", | ||
| "@mui/monorepo": "github:mui/material-ui#0d9333e9f3999d96679a2691e2815296a81475f2", | ||
| "@mui/monorepo": "github:mui/material-ui#288863bd2f8681a82c4bfbaf13215b41043bc551", |
Member
Author
There was a problem hiding this comment.
github-actions
bot
removed
the
PR: out-of-date
Janpot
approved these changes
Jul 22, 2024
Member
Janpot
left a comment
Janpot
left a comment
There was a problem hiding this comment.
Looks great!
We can remove the script once we'll add a bin to the monorepo package.json
DungTiger
pushed a commit
to DungTiger/mui-x
that referenced
this pull request
Jul 23, 2024
thomasmoon
pushed a commit
to thomasmoon/mui-x
that referenced
this pull request
Sep 9, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Follow up to #13360
TODO:
useReactVersionscript reusable in other repos material-ui#42828react-17andreact-nextworkflows on the next branch material-ui#42690