[chart] Use default values instead of non-null assertion to prevent error being thrown #13637
Conversation
JCQuintas
added
type: enhancement
|
Deploy preview: https://deploy-preview-13637--material-ui-x.netlify.app/ |
| {xAxisHighlight === 'band' && axis.x !== null && isBandScale(xScale) && ( | ||
| <ChartsAxisHighlightPath | ||
| d={`M ${xScale(axis.x.value)! - (xScale.step() - xScale.bandwidth()) / 2} ${ | ||
| d={`M ${(xScale(axis.x.value) ?? 0) - (xScale.step() - xScale.bandwidth()) / 2} ${ |
There was a problem hiding this comment.
If xScale(axis.x.value) is not defined, Maybe it would make more sense not to render this component instead of placing it at coordinate 0
There was a problem hiding this comment.
I went with rendering at 0 because it would be clearer that something is wrong, rather than silently failing. Though I don't have a strong preference
There was a problem hiding this comment.
What about logging a warning?
This should not append, but I think it's better to have a non working features that logs in the console why it's not working
There was a problem hiding this comment.
🤔 Wait I did something wrong 😅
| {xAxisHighlight === 'band' && axis.x !== null && isBandScale(xScale) && ( | ||
| <ChartsAxisHighlightPath | ||
| d={`M ${xScale(axis.x.value)! - (xScale.step() - xScale.bandwidth()) / 2} ${ | ||
| d={`M ${(xScale(axis.x.value) ?? 0) - (xScale.step() - xScale.bandwidth()) / 2} ${ |
There was a problem hiding this comment.
What about logging a warning?
This should not append, but I think it's better to have a non working features that logs in the console why it's not working
Co-authored-by: Alexandre Fauquette <[email protected]> Signed-off-by: Jose C Quintas Jr <[email protected]>
alexfauquette
left a comment
alexfauquette
left a comment
There was a problem hiding this comment.
Just a nitpick. Otherwise it's a nice refactoring 👍
packages/x-charts/src/ChartsAxisHighlight/ChartsAxisHighlight.tsx
Outdated
Show resolved
Hide resolved
…rror being thrown (mui#13637) Signed-off-by: Jose C Quintas Jr <[email protected]> Co-authored-by: Alexandre Fauquette <[email protected]>
…rror being thrown (mui#13637) Signed-off-by: Jose C Quintas Jr <[email protected]> Co-authored-by: Alexandre Fauquette <[email protected]>
3 participants
Some cleanup related to #13405 but moved here to make that PR cleaner