[charts] Divide CartesianProvider to use logic in Pro package
#13531
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Deploy preview: https://deploy-preview-13531--material-ui-x.netlify.app/ |
Member
Author
|
Will create conflicts with #13471 |
JCQuintas
added
type: enhancement
Member
alexfauquette
left a comment
alexfauquette
left a comment
There was a problem hiding this comment.
Nice refacto. Just one question to push it a bit further. But I'm not sure it's feasible
packages/x-charts/src/context/CartesianProvider/CartesianContext.ts
Outdated
Show resolved
Hide resolved
packages/x-charts/src/context/CartesianProvider/computeValue.ts
Outdated
Show resolved
Hide resolved
…xt.ts Co-authored-by: Alexandre Fauquette <[email protected]> Signed-off-by: Jose C Quintas Jr <[email protected]>
packages/x-charts/src/context/CartesianProvider/computeValue.ts
Outdated
Show resolved
Hide resolved
packages/x-charts/src/context/CartesianProvider/computeValue.ts
Outdated
Show resolved
Hide resolved
packages/x-charts/src/context/CartesianProvider/computeValue.ts
Outdated
Show resolved
Hide resolved
Co-authored-by: Alexandre Fauquette <[email protected]> Signed-off-by: Jose C Quintas Jr <[email protected]>
Co-authored-by: Alexandre Fauquette <[email protected]> Signed-off-by: Jose C Quintas Jr <[email protected]>
This was referenced Jul 20, 2024
DungTiger
pushed a commit
to DungTiger/mui-x
that referenced
this pull request
Jul 23, 2024
…13531) Signed-off-by: Jose C Quintas Jr <[email protected]> Co-authored-by: Alexandre Fauquette <[email protected]>
thomasmoon
pushed a commit
to thomasmoon/mui-x
that referenced
this pull request
Sep 9, 2024
…13531) Signed-off-by: Jose C Quintas Jr <[email protected]> Co-authored-by: Alexandre Fauquette <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
related #13405