[charts] Fix eslint for react compiler#13444
Conversation
|
Deploy preview: https://deploy-preview-13444--material-ui-x.netlify.app/ |
JCQuintas
left a comment
JCQuintas
left a comment
There was a problem hiding this comment.
Smart move changing the warnedOnce into the closure 👍
| @@ -0,0 +1,17 @@ | |||
| export function buildWarning( | |||
There was a problem hiding this comment.
I would probably just rename it to buildOneTimeWarning or buildWarningOnce
There was a problem hiding this comment.
It's a common piece of code we duplicate in each package.
Was introduced mostly to avoid code duplication in the data grid. We could do the renaming but in that case, would require to do it in all packages
There was a problem hiding this comment.
up to you, doesn't matter much 😅
should we eventually have a shared X package? shouldn't be too hard to accomplish
There was a problem hiding this comment.
should we eventually have a shared X package?
This has been discussed quite recently
I feel like we are only waiting for a use-case and someone to own the creation of the new package 😆
@joserodolfofreitas @cherniavskii if you are OK, we can create it
There was a problem hiding this comment.
Agreed, we need a shared utils package 👍🏻
5 participants
Not sure it's the best way to fix warnings about no side effect, but it works 😇