Skip to content

[charts] Simplify plugin types #13396

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 4 commits into from
Jun 6, 2024
Merged

[charts] Simplify plugin types #13396

merged 4 commits into from
Jun 6, 2024

Conversation

@JCQuintas
Copy link
Member

@JCQuintas JCQuintas commented Jun 6, 2024

@JCQuintas JCQuintas requested a review from alexfauquette June 6, 2024 09:18
@JCQuintas JCQuintas mentioned this pull request Jun 6, 2024
Merged
@JCQuintas JCQuintas self-assigned this Jun 6, 2024
@JCQuintas JCQuintas added type: enhancement It’s an improvement, but we can’t make up our mind whether it's a bug fix or a new feature. scope: charts Changes related to the charts. labels Jun 6, 2024
@JCQuintas JCQuintas changed the title Simpler plugin types [charts] Simpler plugin types Jun 6, 2024
@mui-bot
Copy link

mui-bot commented Jun 6, 2024 •
edited
Loading

Deploy preview: https://deploy-preview-13396--material-ui-x.netlify.app/

Generated by 🚫 dangerJS against 4c3eda4

@JCQuintas JCQuintas mentioned this pull request Jun 6, 2024
Merged
@alexfauquette alexfauquette changed the title [charts] Simpler plugin types [charts] Simplify plugin types Jun 6, 2024
alexfauquette
alexfauquette approved these changes Jun 6, 2024
View reviewed changes
Copy link
Member

@alexfauquette alexfauquette left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍

@JCQuintas @alexfauquette
Update packages/x-charts/src/ChartContainer/defaultPlugins.ts
b43e1e6 
Co-authored-by: Alexandre Fauquette <[email protected]>
Signed-off-by: Jose C Quintas Jr <[email protected]>
@JCQuintas JCQuintas enabled auto-merge (squash) June 6, 2024 10:44
alexfauquette
alexfauquette reviewed Jun 6, 2024
View reviewed changes
@JCQuintas JCQuintas disabled auto-merge June 6, 2024 11:26
@JCQuintas JCQuintas enabled auto-merge (squash) June 6, 2024 11:34
@JCQuintas JCQuintas merged commit 02aa2f1 into mui:master Jun 6, 2024
@JCQuintas JCQuintas deleted the plugin-types branch June 6, 2024 11:39
This was referenced Jul 12, 2024
Merged
Merged
@alhabib5565 alhabib5565 mentioned this pull request Jul 14, 2024
Open
@KotoneZQ KotoneZQ mentioned this pull request Jul 18, 2024
Open
DungTiger pushed a commit to DungTiger/mui-x that referenced this pull request Jul 23, 2024
@JCQuintas @alexfauquette @DungTiger
[charts] Simplify plugin types (mui#13396)
e982256 
Signed-off-by: Jose C Quintas Jr <[email protected]>
Signed-off-by: Alexandre Fauquette <[email protected]>
Co-authored-by: Alexandre Fauquette <[email protected]>
thomasmoon pushed a commit to thomasmoon/mui-x that referenced this pull request Sep 9, 2024
@JCQuintas @alexfauquette @thomasmoon
[charts] Simplify plugin types (mui#13396)
85ab221 
Signed-off-by: Jose C Quintas Jr <[email protected]>
Signed-off-by: Alexandre Fauquette <[email protected]>
Co-authored-by: Alexandre Fauquette <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@alexfauquette alexfauquette alexfauquette approved these changes

Assignees

@JCQuintas JCQuintas

Labels

scope: charts Changes related to the charts. type: enhancement It’s an improvement, but we can’t make up our mind whether it's a bug fix or a new feature.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@JCQuintas @mui-bot @alexfauquette