[DataGridPro] Keep bottom pinned row at the bottom #13313
Conversation
romgrk
added
scope: data grid
|
Deploy preview: https://deploy-preview-13313--material-ui-x.netlify.app/ |
packages/x-data-grid/src/components/virtualization/GridVirtualScroller.tsx
Show resolved
Hide resolved
cherniavskii
left a comment
cherniavskii
left a comment
There was a problem hiding this comment.
Looks good!
Can you add a unit test for this regression?
cherniavskii
added
plan: Pro
cherniavskii
changed the title
| // In cases where the columns exceed the available width, | ||
| // the horizontal scrollbar should be shown even when there're no rows. | ||
| // Keeping 1px as minimum height ensures that the scrollbar will visible if necessary. | ||
| const height = Math.max(contentHeight, 1); | ||
|
|
There was a problem hiding this comment.
I think this code was preventing this 0-height warning from running in some cases, so fixing it broke some tests all over the place that didn't have explicit dimensions on the grid container. I'll need to debug & update those tests before merging this PR. The test runner also doesn't seem to match the warning to which test it originated from precisely, so sometimes it marks one test as failed but the warning came from another test. As in if I run the test with .only it succeeds, but if I run the test suite as a whole it fails. Lots of fun ahead.
5 participants
Closes #12925
Before: https://codesandbox.io/p/sandbox/funny-leaf-6fv4qt
After: https://codesandbox.io/p/sandbox/mui-mui-x-x-data-grid-forked-9vpwwk