-
-
Notifications
You must be signed in to change notification settings - Fork 32.7k
[material-ui][CircularProgress] Add track slot via enableTrackSlot #46907
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[material-ui][CircularProgress] Add track slot via enableTrackSlot #46907
Conversation
Netlify deploy previewBundle size report
|
85847e4 to
8f70499
Compare
|
Sorry, I missed those changes because I had some work in progress. |
siriwatknp
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
👍 Great job.
Pushed minor tweaks to use the theme token
|
Request a second eye from @sai6855 |
sai6855
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM as well 👍
|
@siriwatknp I don't see |
Yes, please proceed for both Circular and Linear Progress (can be in the same PR). |
closes #46863
Summary
Adds a customizable track slot to
CircularProgressand updates docs/API/tests.enableTrackSlot?: boolean(default false).MuiCircularProgress-track<circle>(samer/strokeWidthas the foreground,aria-hidden="true", no dash indeterminate)CircularEnableTrackdemo; update API docs to include the prop and classdeterminatenote1: The docs section is titled “Circular track”. I’m open to renaming it to “Circular enableTrack” if reviewers prefer aligning the demo title with the prop name.
note2: I intentionally didn’t include dash customization for the track in this PR to keep the scope focused. If you believe this feature would be useful, please open a new issue and assign it to me; I’d be happy to proceed with a follow-up PR.
Demo