[material-ui] Fix slotProps.transition types
#45367
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
siriwatknp
added
typescript
cherry-pick
Netlify deploy previewhttps://deploy-preview-45367--material-ui.netlify.app/ Bundle size report |
DiegoAndai
reviewed
Feb 20, 2025
Member
DiegoAndai
left a comment
DiegoAndai
left a comment
There was a problem hiding this comment.
@siriwatknp I'm wondering if we should cherry-pick this one 🤔
It might be considered a breaking change. What do you think?
Member
Author
I don't think it's a breaking change because the types is widening. I explained it in the PR description and TypeScript playground. |
DiegoAndai
approved these changes
Feb 21, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
cherry pick #45214