[code-infra] Use the same CI names on master & next #43064
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mnajdova
added
the
internal
Netlify deploy previewhttps://deploy-preview-43064--material-ui.netlify.app/ Bundle size report |
cherniavskii
approved these changes
Jul 25, 2024
There was a problem hiding this comment.
I wasn't aware there was a list of required jobs somewhere.
Where can I find it?
There was a problem hiding this comment.
It is under https://github.com/mui/material-ui/settings/rules/549978. I am not sure what are the roles that have access, but there is a ruleset that sets the require status check to be passed, e.g.
There was a problem hiding this comment.
Ah, it's defined on GitHub 👍🏻
I don't have access, but it's good to know where it's defined, thanks!
cherniavskii
added
the
scope: code-infra
This was referenced Aug 21, 2024
This was referenced Aug 21, 2024
This was referenced Aug 21, 2024
This was referenced Aug 21, 2024
This was referenced Aug 21, 2024
This was referenced Aug 21, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Cherry pick of (#42690)
We need to apply the change of renamed CI checks on master too, as we are using the same rules for master & next in terms of required checks. Without this change, we continued to see pending checks on master, as the checks with the new names don't exist on this branch.