[material-ui][Dialog] Prevent onClick on the root element from being overwritten #41881
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
oliviertassinari
added
type: bug
Co-authored-by: Olivier Tassinari <[email protected]> Signed-off-by: Ryan Burr <[email protected]>
Member
ZeeshanTamboli
left a comment
ZeeshanTamboli
left a comment
There was a problem hiding this comment.
Looks good. Left one comment.
Netlify deploy previewhttps://deploy-preview-41881--material-ui.netlify.app/ Bundle size reportDetails of bundle changes (Toolpad) |
ZeeshanTamboli
changed the title
ZeeshanTamboli
approved these changes
Apr 15, 2024
Member
ZeeshanTamboli
left a comment
ZeeshanTamboli
left a comment
There was a problem hiding this comment.
Thanks for the pull request!
ZeeshanTamboli
added
the
needs cherry-pick
github-actions bot
pushed a commit
that referenced
this pull request
Apr 15, 2024
…overwritten (#41881) Signed-off-by: Ryan Burr <[email protected]> Co-authored-by: ZeeshanTamboli <[email protected]>
Contributor
Author
|
@ZeeshanTamboli thanks for the assist! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR fixes #41417
onClickprop from being overwritten by destructing and invoking on local handler.