Skip to content

[docs-infra] Improve Twitter OG:image #41860

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Apr 19, 2024
Merged

[docs-infra] Improve Twitter OG:image #41860

merged 1 commit into from
Apr 19, 2024

Conversation

@oliviertassinari
Copy link
Member

@oliviertassinari oliviertassinari commented Apr 11, 2024 •
edited
Loading

Revert #32536, since we have #41188 now 👌. I wanted to tweet to celebrate this change as it's a nice DX improvement, but got blocked by this.

Before
SCR-20240411-pgxo

@oliviertassinari oliviertassinari added type: enhancement It’s an improvement, but we can’t make up our mind whether it's a bug fix or a new feature. scope: docs-infra Involves the docs-infra product (https://www.notion.so/mui-org/b9f676062eb94747b6768209f7751305). labels Apr 11, 2024
@mui-bot
Copy link

mui-bot commented Apr 11, 2024 •
edited
Loading

Netlify deploy preview

https://deploy-preview-41860--material-ui.netlify.app/

Bundle size report

No bundle size changes (Toolpad)
No bundle size changes

Generated by 🚫 dangerJS against b674117

@oliviertassinari oliviertassinari added the cherry-pick The PR was cherry-picked from the newer alpha/beta/stable branch. label Apr 19, 2024
@oliviertassinari oliviertassinari merged commit 1614283 into mui:next Apr 19, 2024
@oliviertassinari oliviertassinari deleted the og-image-twitter branch April 19, 2024 22:00
@oliviertassinari oliviertassinari added needs cherry-pick The PR should be cherry-picked to master after merge. and removed cherry-pick The PR was cherry-picked from the newer alpha/beta/stable branch. labels Apr 19, 2024
oliviertassinari added a commit that referenced this pull request Apr 19, 2024
@oliviertassinari
[docs-infra] Improve Twitter OG:image (#41860)
bc22c6f
This was referenced May 22, 2024
Open
Open
@mxiloyannis mxiloyannis mentioned this pull request May 22, 2024
Closed
@brahim77777 brahim77777 mentioned this pull request May 22, 2024
Open
This was referenced May 22, 2024
Open
Open
This was referenced May 22, 2024
Open
Open
Open
This was referenced May 22, 2024
Open
Open
@swirlds-automation swirlds-automation mentioned this pull request May 22, 2024
Merged
@mattboddy47 mattboddy47 mentioned this pull request May 22, 2024
Open
This was referenced May 22, 2024
Closed
Closed
This was referenced May 22, 2024
Open
Open
This was referenced May 22, 2024
Open
Open
@mattboddy47 mattboddy47 mentioned this pull request Jun 19, 2024
Open
@Poseidon-G Poseidon-G mentioned this pull request Jun 20, 2024
Open
This was referenced Jun 20, 2024
Merged
Merged
This was referenced Jun 20, 2024
Open
Open
This was referenced Jun 20, 2024
Open
Open
@dsypasit dsypasit mentioned this pull request Jun 20, 2024
Closed
@nachodev-ui nachodev-ui mentioned this pull request Jun 20, 2024
Open
This was referenced Jun 20, 2024
Open
Open
@abjerry97 abjerry97 mentioned this pull request Jun 21, 2024
Open
@jookzie jookzie mentioned this pull request Jun 22, 2024
Merged
@FelixAshong FelixAshong mentioned this pull request Jun 22, 2024
Merged
@Rossen27 Rossen27 mentioned this pull request Jun 22, 2024
Open
This was referenced Jun 25, 2024
Merged
Merged
@DanneelsSophie DanneelsSophie mentioned this pull request Jun 25, 2024
Open
@Poseidon-G Poseidon-G mentioned this pull request Jun 25, 2024
Open
This was referenced Jun 25, 2024
Merged
Merged
This was referenced Jun 26, 2024
Open
Open
@Type-Style Type-Style mentioned this pull request Jun 27, 2024
Closed
@DanneelsSophie DanneelsSophie mentioned this pull request Jun 29, 2024
Open
@IrvingYHM IrvingYHM mentioned this pull request Jun 29, 2024
Closed
@Poseidon-G Poseidon-G mentioned this pull request Jun 29, 2024
Open
@DanneelsSophie DanneelsSophie mentioned this pull request Jul 1, 2024
Open
@Poseidon-G Poseidon-G mentioned this pull request Jul 3, 2024
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@alexfauquette alexfauquette Awaiting requested review from alexfauquette

Assignees

No one assigned

Labels

needs cherry-pick The PR should be cherry-picked to master after merge. scope: docs-infra Involves the docs-infra product (https://www.notion.so/mui-org/b9f676062eb94747b6768209f7751305). type: enhancement It’s an improvement, but we can’t make up our mind whether it's a bug fix or a new feature.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@oliviertassinari @mui-bot