Skip to content

[material-ui][Select] Fix muiName property TypeScript error (@EyaOuenniche) #41786

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
Apr 6, 2024
Merged

[material-ui][Select] Fix muiName property TypeScript error (@EyaOuenniche) #41786

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
bdd62dc
[material-ui][Select] Fix `muiName` property TypeScript error (#41726)
EyaOuenniche Apr 6, 2024
a19bb79
rerun CI
ZeeshanTamboli Apr 6, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
15 changes: 9 additions & 6 deletions packages/mui-material/src/Select/Select.d.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -151,23 +151,26 @@ export interface BaseSelectProps<Value = unknown>
variant?: SelectVariants;
}

export interface FilledSelectProps extends Omit<FilledInputProps, 'value' | 'onChange'> {
export interface FilledSelectProps
extends Omit<FilledInputProps, 'value' | 'onChange' | 'id' | 'classes' | 'inputProps'> {
/**
* The variant to use.
* @default 'outlined'
*/
variant: 'filled';
}

export interface StandardSelectProps extends Omit<InputProps, 'value' | 'onChange'> {
export interface StandardSelectProps
extends Omit<InputProps, 'value' | 'onChange' | 'id' | 'classes' | 'inputProps'> {
/**
* The variant to use.
* @default 'outlined'
*/
variant: 'standard';
}

export interface OutlinedSelectProps extends Omit<OutlinedInputProps, 'value' | 'onChange'> {
export interface OutlinedSelectProps
extends Omit<OutlinedInputProps, 'value' | 'onChange' | 'id' | 'classes' | 'inputProps'> {
/**
* The variant to use.
* @default 'outlined'
Expand All @@ -193,8 +196,8 @@ export type SelectProps<Value = unknown> =
* - [Select API](https://mui.com/material-ui/api/select/)
* - inherits [OutlinedInput API](https://mui.com/material-ui/api/outlined-input/)
*/
export default function Select<Value = unknown>(
props: SelectProps<Value>,
): JSX.Element & {
declare const Select: (<Value = unknown>(props: SelectProps<Value>) => JSX.Element) & {
muiName: string;
};

export default Select;
3 changes: 3 additions & 0 deletions packages/mui-material/src/Select/Select.spec.tsx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -196,3 +196,6 @@ const AppSelect = <T extends string>(props: Props<T>) => {
</Select>
);
};

// test for applying Select's static muiName property type to wrapper components
AppSelect.muiName = Select.muiName;