Skip to content

Conversation

@Janpot
Copy link
Member

@Janpot Janpot commented Mar 13, 2024

Copy translation files into the build folder. These are unfortunately not automatically copied to the build folder as our build system only simply transpiles a set of source files and doesn't resolve imports correctly as a real bundler would.

Fixes #41246 (comment)

@Janpot Janpot added the scope: code-infra Involves the code-infra product (https://www.notion.so/mui-org/5562c14178aa42af97bc1fa5114000cd). label Mar 13, 2024
@mui-bot
Copy link

mui-bot commented Mar 13, 2024

Netlify deploy preview

https://deploy-preview-41472--material-ui.netlify.app/

Bundle size report

No bundle size changes (Toolpad)
No bundle size changes

Generated by 🚫 dangerJS against 675a013

@Janpot Janpot marked this pull request as ready for review March 13, 2024 11:59
@Janpot Janpot requested a review from michaldudak March 13, 2024 11:59
Copy link
Member

@michaldudak michaldudak left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Seems to be working well!

@Janpot Janpot merged commit d26d07e into mui:master Mar 13, 2024
@Janpot Janpot deleted the copy-translations branch March 13, 2024 14:32
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

scope: code-infra Involves the code-infra product (https://www.notion.so/mui-org/5562c14178aa42af97bc1fa5114000cd).

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants