Skip to content

[pigment] Rename directories to match package names #41453

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Mar 12, 2024
Merged

[pigment] Rename directories to match package names #41453

merged 1 commit into from
Mar 12, 2024

Conversation

@brijeshb42
Copy link
Contributor

@brijeshb42 brijeshb42 commented Mar 11, 2024 •
edited
Loading

I have kept the pigment-react/README.md to link to the new directory.

Closes #41332

@brijeshb42 brijeshb42 added the package: pigment-css Specific to Pigment CSS. label Mar 11, 2024
@mui-bot
Copy link

mui-bot commented Mar 11, 2024 •
edited
Loading

Netlify deploy preview

https://deploy-preview-41453--material-ui.netlify.app/

Bundle size report

No bundle size changes (Toolpad)
No bundle size changes

Generated by 🚫 dangerJS against ee13a96

@brijeshb42 brijeshb42 force-pushed the pigment/rename-directory branch from 134fbd2 to 1bf2863 Compare March 11, 2024 17:39
oliviertassinari
oliviertassinari reviewed Mar 11, 2024
View reviewed changes
Copy link
Member

@oliviertassinari oliviertassinari left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Great, thanks 👍

@brijeshb42 brijeshb42 enabled auto-merge (squash) March 11, 2024 18:37
@github-actions github-actions bot added the PR: out-of-date The pull request has merge conflicts and can't be merged. label Mar 12, 2024
@brijeshb42 brijeshb42 force-pushed the pigment/rename-directory branch from 1bf2863 to 7e31fcc Compare March 12, 2024 08:40
@github-actions github-actions bot removed the PR: out-of-date The pull request has merge conflicts and can't be merged. label Mar 12, 2024
siriwatknp
siriwatknp approved these changes Mar 12, 2024
View reviewed changes
Copy link
Member

@siriwatknp siriwatknp left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please recheck the CI, the rest looks good.

@brijeshb42 brijeshb42 force-pushed the pigment/rename-directory branch from 7e31fcc to ee13a96 Compare March 12, 2024 10:19
@brijeshb42 brijeshb42 merged commit 828f4da into mui:master Mar 12, 2024
@brijeshb42 brijeshb42 deleted the pigment/rename-directory branch March 12, 2024 10:45
@oliviertassinari oliviertassinari added the internal Behind-the-scenes enhancement. Formerly called “core”. label Mar 12, 2024
This was referenced May 19, 2024
Open
Open
Open
This was referenced May 19, 2024
Open
Open
@nachodev-ui nachodev-ui mentioned this pull request May 20, 2024
Open
@FaroukAmr FaroukAmr mentioned this pull request May 20, 2024
Open
@jfnw-capco jfnw-capco mentioned this pull request May 20, 2024
Open
This was referenced May 20, 2024
Open
Open
This was referenced May 20, 2024
Open
Open
@sergivj sergivj mentioned this pull request May 21, 2024
Open
@NOUIY NOUIY mentioned this pull request May 21, 2024
Open
@NOUIY NOUIY mentioned this pull request May 21, 2024
Open
@RTHariSankar RTHariSankar mentioned this pull request May 21, 2024
Open
@GitLukeW GitLukeW mentioned this pull request May 21, 2024
Open
@aqibawan12 aqibawan12 mentioned this pull request May 21, 2024
Open
@Poseidon-G Poseidon-G mentioned this pull request May 21, 2024
Open
@Crushoverride007 Crushoverride007 mentioned this pull request May 21, 2024
Open
@mxiloyannis mxiloyannis mentioned this pull request May 21, 2024
Closed
@DanneelsSophie DanneelsSophie mentioned this pull request May 22, 2024
Open
@heliumtank92 heliumtank92 mentioned this pull request Jun 8, 2024
Open
@Helmut-Tischler Helmut-Tischler mentioned this pull request Jun 10, 2024
Open
This was referenced Jun 15, 2024
Open
Open
@dsypasit dsypasit mentioned this pull request Jun 20, 2024
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@oliviertassinari oliviertassinari oliviertassinari left review comments

@siriwatknp siriwatknp siriwatknp approved these changes

Assignees

No one assigned

Labels

internal Behind-the-scenes enhancement. Formerly called “core”. package: pigment-css Specific to Pigment CSS.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

[pigment-css][core] Use npm package name for folder name

4 participants

@brijeshb42 @mui-bot @oliviertassinari @siriwatknp